From: "Yan, Zheng" <zheng.z.yan@intel.com>
To: "netdev@vger.kernel.org" <netdev@vger.kernel.org>
Cc: Herbert Xu <herbert@gondor.apana.org.au>,
"davem@davemloft.net" <davem@davemloft.net>
Subject: [PATCH] xfrm: fix error checking in xfrm_output_gso
Date: Thu, 27 Oct 2011 13:33:18 +0800 [thread overview]
Message-ID: <4EA8ED1E.6080808@intel.com> (raw)
xfrm_output2() returns 1 on success. This bug makes xfrm_output_gso()
drop all segments except the first one.
Signed-off-by: Zheng Yan <zheng.z.yan@intel.com>
---
diff --git a/net/xfrm/xfrm_output.c b/net/xfrm/xfrm_output.c
index 47bacd8..04e963a 100644
--- a/net/xfrm/xfrm_output.c
+++ b/net/xfrm/xfrm_output.c
@@ -159,7 +159,7 @@ static int xfrm_output_gso(struct sk_buff *skb)
segs->next = NULL;
err = xfrm_output2(segs);
- if (unlikely(err)) {
+ if (unlikely(err < 0)) {
while ((segs = nskb)) {
nskb = segs->next;
segs->next = NULL;
next reply other threads:[~2011-10-27 5:33 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-27 5:33 Yan, Zheng [this message]
2011-10-28 0:47 ` [PATCH] xfrm: fix error checking in xfrm_output_gso Yan, Zheng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4EA8ED1E.6080808@intel.com \
--to=zheng.z.yan@intel.com \
--cc=davem@davemloft.net \
--cc=herbert@gondor.apana.org.au \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.