From: Hannes Reinecke <hare@suse.de>
To: device-mapper development <dm-devel@redhat.com>
Cc: "Moger, Babu" <Babu.Moger@netapp.com>,
Linux SCSI Mailing list <linux-scsi@vger.kernel.org>
Subject: Re: [dm-devel] [PATCH] scsi_dh: check queuedata pointer before proceeding further
Date: Thu, 27 Oct 2011 08:25:42 +0200 [thread overview]
Message-ID: <4EA8F966.6050008@suse.de> (raw)
In-Reply-To: <47D23AD8469A2B448F33C24BD7A39BD91040F25B@RTPMVEXC1-PRD.hq.netapp.com>
On 10/26/2011 08:29 PM, Moger, Babu wrote:
> This patch validates sdev pointer in scsi_dh_activate before proceeding further.
>
> Without this check we might see the panic as below. I have seen this
> panic multiple times..
>
> Call trace:
>
> #0 [ffff88007d647b50] machine_kexec at ffffffff81020902
> #1 [ffff88007d647ba0] crash_kexec at ffffffff810875b0
> #2 [ffff88007d647c70] oops_end at ffffffff8139c650
> #3 [ffff88007d647c90] __bad_area_nosemaphore at ffffffff8102dd15
> #4 [ffff88007d647d50] page_fault at ffffffff8139b8cf
> [exception RIP: scsi_dh_activate+0x82]
> RIP: ffffffffa0041922 RSP: ffff88007d647e00 RFLAGS: 00010046
> RAX: 0000000000000000 RBX: 0000000000000000 RCX: 00000000000093c5
> RDX: 00000000000093c5 RSI: ffffffffa02e6640 RDI: ffff88007cc88988
> RBP: 000000000000000f R8: ffff88007d646000 R9: 0000000000000000
> R10: ffff880082293790 R11: 00000000ffffffff R12: ffff88007cc88988
> R13: 0000000000000000 R14: 0000000000000286 R15: ffff880037b845e0
> ORIG_RAX: ffffffffffffffff CS: 0010 SS: 0000
> #5 [ffff88007d647e38] run_workqueue at ffffffff81060268
> #6 [ffff88007d647e78] worker_thread at ffffffff81060386
> #7 [ffff88007d647ee8] kthread at ffffffff81064436
> #8 [ffff88007d647f48] kernel_thread at ffffffff81003fba
>
> Signed-off-by: Babu Moger <babu.moger@netapp.com>
Acked-by: Hannes Reinecke <hare@suse.de>
Cheers,
Hannes
--
Dr. Hannes Reinecke zSeries & Storage
hare@suse.de +49 911 74053 688
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Markus Rex, HRB 16746 (AG Nürnberg)
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
prev parent reply other threads:[~2011-10-27 6:25 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-26 18:29 [PATCH] scsi_dh: check queuedata pointer before proceeding further Moger, Babu
2011-10-27 6:25 ` Hannes Reinecke [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4EA8F966.6050008@suse.de \
--to=hare@suse.de \
--cc=Babu.Moger@netapp.com \
--cc=dm-devel@redhat.com \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.