From: Kevin Wolf <kwolf@redhat.com>
To: Stefan Hajnoczi <stefanha@gmail.com>
Cc: qemu-devel@nongnu.org, Ronnie Sahlberg <ronniesahlberg@gmail.com>
Subject: Re: [Qemu-devel] [PATCH] Documentation: add new section for device URL syntax for special files and describe the iSCSI URL with examples
Date: Thu, 27 Oct 2011 11:35:34 +0200 [thread overview]
Message-ID: <4EA925E6.2080002@redhat.com> (raw)
In-Reply-To: <20111027071446.GB32287@stefanha-thinkpad.localdomain>
Am 27.10.2011 09:14, schrieb Stefan Hajnoczi:
> On Wed, Oct 26, 2011 at 11:51:37PM +1100, Ronnie Sahlberg wrote:
>>
>> Signed-off-by: Ronnie Sahlberg <ronniesahlberg@gmail.com>
>> ---
>> qemu-options.hx | 42 ++++++++++++++++++++++++++++++++++++++++++
>> 1 files changed, 42 insertions(+), 0 deletions(-)
>
> Good idea, thanks for adding documentation.
>
> Reviewed-by: Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>
Breaks the build. I'll amend the commit with the following changes:
diff --git a/qemu-options.hx b/qemu-options.hx
index 7c434f8..f967fb9 100644
--- a/qemu-options.hx
+++ b/qemu-options.hx
@@ -1719,6 +1719,7 @@ Connect to a spice virtual machine channel, such
as vdiport.
@end table
ETEXI
+STEXI
DEFHEADING()
DEFHEADING(Device URL Syntax:)
@@ -1727,7 +1728,6 @@ In addition to using normal file images for the
emulated storage devices,
QEMU can also use networked resources such as iSCSI devices. These are
specified using a special URL syntax.
-STEXI
@table @option
@item iSCSI
iSCSI support allows QEMU to access iSCSI resources directly and use as
@@ -1744,7 +1744,7 @@ qemu -cdrom
iscsi://192.0.2.1/iqn.2001-04.com.example/2 \
Example (CHAP username/password via URL):
@example
-qemu --drive file=iscsi://user%password@192.0.2.1/iqn.2001-04.com.example/1
+qemu --drive
file=iscsi://user%password@@192.0.2.1/iqn.2001-04.com.example/1
@end example
Example (CHAP username/password via environment variables):
next prev parent reply other threads:[~2011-10-27 9:32 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-26 12:51 [Qemu-devel] [PATCH 0/0] Add mention of iSCSI devices to manpage Ronnie Sahlberg
2011-10-26 12:51 ` [Qemu-devel] [PATCH] Documentation: add new section for device URL syntax for special files and describe the iSCSI URL with examples Ronnie Sahlberg
2011-10-27 7:14 ` Stefan Hajnoczi
2011-10-27 9:35 ` Kevin Wolf [this message]
2011-10-27 8:52 ` Kevin Wolf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4EA925E6.2080002@redhat.com \
--to=kwolf@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=ronniesahlberg@gmail.com \
--cc=stefanha@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.