From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:52636) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RJOZM-0000YW-Iq for qemu-devel@nongnu.org; Thu, 27 Oct 2011 07:56:25 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RJOZL-00021O-D6 for qemu-devel@nongnu.org; Thu, 27 Oct 2011 07:56:24 -0400 Received: from mx1.redhat.com ([209.132.183.28]:26184) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RJOZL-00021H-6A for qemu-devel@nongnu.org; Thu, 27 Oct 2011 07:56:23 -0400 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id p9RBuLvX024153 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Thu, 27 Oct 2011 07:56:21 -0400 Message-ID: <4EA946DD.40304@redhat.com> Date: Thu, 27 Oct 2011 13:56:13 +0200 From: Gerd Hoffmann MIME-Version: 1.0 References: <1319549990-26462-1-git-send-email-alevy@redhat.com> In-Reply-To: <1319549990-26462-1-git-send-email-alevy@redhat.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] qxl: create slots on post_load in vga state List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Alon Levy Cc: qemu-devel@nongnu.org On 10/25/11 15:39, Alon Levy wrote: > RHBZ 740547 > > If we migrate when the device is in vga state the guest > still believes the slots are created, and will cause operations > that reference the slots, causing a "panic: virtual address out of range" > on the first of them. Easy to see by migrating in vga mode with > a driver loaded, for instance windows cmd window in full screen mode, > and then exiting vga mode back to native mode will cause said panic. > > Fixed by doing the slot recreation in post_load for vga mode as well. > Note that compat does not require any changes because it creates it's > only slot by a side effect of QXL_IO_SET_MODE. > > Signed-off-by: Alon Levy > --- > v4: > don't print unused delta in qxl_create_memslots > v3: > no need to create slots in compat mode, they are created by qxl_set_mode. > Patch added to spice patch queue. thanks, Gerd