From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:51925) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RJRcs-0003Vt-Ld for qemu-devel@nongnu.org; Thu, 27 Oct 2011 11:12:20 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RJRcr-0002oQ-MS for qemu-devel@nongnu.org; Thu, 27 Oct 2011 11:12:14 -0400 Received: from mx1.redhat.com ([209.132.183.28]:21087) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RJRcr-0002oK-Ca for qemu-devel@nongnu.org; Thu, 27 Oct 2011 11:12:13 -0400 Message-ID: <4EA974C4.9010004@redhat.com> Date: Thu, 27 Oct 2011 17:12:04 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <1319715472-16286-1-git-send-email-peter.maydell@linaro.org> <1319715472-16286-4-git-send-email-peter.maydell@linaro.org> <4EA9747B.7010703@suse.de> In-Reply-To: <4EA9747B.7010703@suse.de> Content-Type: text/plain; charset=ISO-8859-15; format=flowed Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH v2 3/3] Make cpu_single_env thread-local List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: =?ISO-8859-15?Q?Andreas_F=E4rber?= Cc: Peter Maydell , patches@linaro.org, "Dr. David Alan Gilbert" , qemu-devel@nongnu.org, Jan Kiszka On 10/27/2011 05:10 PM, Andreas F=E4rber wrote: > Am 27.10.2011 13:37, schrieb Peter Maydell: >> From: Paolo Bonzini >> >> Make cpu_single_env thread-local. This fixes a regression >> in handling of multi-threaded programs in linux-user mode >> (bug 823902). >> >> Signed-off-by: Paolo Bonzini >> [Peter Maydell: rename tls_cpu_single_env to cpu_single_env] >> Signed-off-by: Peter Maydell >> --- >> cpu-all.h | 4 +++- >> exec.c | 2 +- >> 2 files changed, 4 insertions(+), 2 deletions(-) >> >> diff --git a/cpu-all.h b/cpu-all.h >> index 42a5fa0..5f47ab8 100644 >> --- a/cpu-all.h >> +++ b/cpu-all.h >> @@ -20,6 +20,7 @@ >> #define CPU_ALL_H >> >> #include "qemu-common.h" >> +#include "qemu-tls.h" >> #include "cpu-common.h" >> >> /* some important defines: > [8<] > > Is there a reason not to include this from qemu-common.h? To avoid > accidental use in unsuited cases? If so, add an explicit comment to > either qemu-common.h or Jan's comment in qemu-tls.h to avoid someone > doing such a cleanup/simplification patch? I think we're evolving towards having qemu-common.h as a common place=20 for system header inclusions, but not really for QEMU-specific headers. Paolo