All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mark Lord <kernel@teksavvy.com>
To: David Miller <davem@davemloft.net>
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: asix usb network driver: nfg
Date: Thu, 27 Oct 2011 14:48:03 -0400	[thread overview]
Message-ID: <4EA9A763.3000607@teksavvy.com> (raw)
In-Reply-To: <20111026.221719.2216112919297458522.davem@davemloft.net>

On 11-10-26 10:17 PM, David Miller wrote:
> From: Mark Lord <kernel@teksavvy.com>
> Date: Wed, 26 Oct 2011 21:23:15 -0400
> 
>> Any strong advance objections to replacing the in-kernel version
>> with a (fixed) vendor open source version?
> 
> It need to meet the coding etc. standards for inclusion, last
> time I looked at it their driver indeed need a bit of cleaning up.

Yeah, okay -- I've got approval to spend some paid time on the effort,
so I'll have a deeper look at things.

> It's a sad situation, they started with the upstream driver and
> just hacked on it however they pleased in their private copy.
> So now we have this huge divergance and no effort on their part
> to rectify things.

Will there be any issues with "Signed-Off-By" on this?
It's all GPL, by License, but we don't necessarily know who
make what changes to their driver since they forked it.
I don't think that matters much, but then what I think doesn't matter much
either. :)

But it is the only one of the two that's close to working
(and does work when DEBUG messages are enabled -- a timing issue
somewhere that I'll fix).

Thanks David.

  reply	other threads:[~2011-10-27 18:48 UTC|newest]

Thread overview: 36+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-10-26 23:36 asix usb network driver: nfg Mark Lord
2011-10-26 23:40 ` David Miller
2011-10-27  1:23   ` Mark Lord
2011-10-27  2:17     ` David Miller
2011-10-27 18:48       ` Mark Lord [this message]
2011-11-02 19:36       ` [PATCH] drivers/net/usb/asix: resync from vendor's copy Mark Lord
2011-11-02 19:48         ` Mark Lord
2011-11-02 20:42         ` Ben Hutchings
2011-11-02 22:44           ` Mark Lord
2011-11-09 16:25           ` Mark Lord
2011-11-09 16:34             ` Ben Hutchings
2011-11-09 16:47               ` Mark Lord
2011-11-09 16:57                 ` Mark Lord
2011-11-09 17:20                   ` Mark Lord
2011-11-09 17:31                     ` Ben Hutchings
2011-11-09 17:40                       ` Mark Lord
2011-11-09 17:48                         ` Ben Hutchings
2011-11-09 18:22                           ` Mark Lord
2011-12-05 14:41                           ` Mark Lord
2011-12-05 15:18                             ` Ben Hutchings
2011-12-06 12:44                               ` Mark Lord
2011-12-06 17:45                                 ` Ben Hutchings
2011-12-07 16:21                                   ` Mark Lord
2011-12-07 16:27                                     ` Ben Hutchings
2011-12-07 16:59                                       ` Mark Lord
2011-12-07 17:03                                         ` Ben Hutchings
2011-11-07 16:09         ` Michal Marek
2011-11-09 17:31         ` [PATCH v2] " Mark Lord
2011-11-09 17:41           ` Mark Lord
2011-11-09 17:43           ` Mark Lord
2011-11-09 17:47           ` Ben Hutchings
2011-11-09 18:27             ` Mark Lord
2011-11-09 17:49           ` [PATCH v3] " Mark Lord
2011-11-10 14:01           ` [PATCH v2] " Mark Lord
2011-11-10 16:54             ` Grant Grundler
2011-11-10 20:17               ` Mark Lord

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4EA9A763.3000607@teksavvy.com \
    --to=kernel@teksavvy.com \
    --cc=davem@davemloft.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.