All of lore.kernel.org
 help / color / mirror / Atom feed
From: Suzuki Poulose <suzuki@in.ibm.com>
To: Scott Wood <scottwood@freescale.com>
Cc: Michal Simek <monstr@monstr.eu>,
	tmarri@apm.com,
	Mahesh Jagannath Salgaonkar <mahesh@linux.vnet.ibm.com>,
	Dave Hansen <dave@linux.vnet.ibm.com>,
	David Laight <David.Laight@ACULAB.COM>,
	Paul Mackerras <paulus@samba.org>,
	linux ppc dev <linuxppc-dev@lists.ozlabs.org>,
	Vivek Goyal <vgoyal@redhat.com>
Subject: Re: [PATCH 2/3] [44x] Enable CONFIG_RELOCATABLE for PPC44x
Date: Fri, 28 Oct 2011 10:33:09 +0530	[thread overview]
Message-ID: <4EAA378D.2080304@in.ibm.com> (raw)
In-Reply-To: <4EA97BB1.8020009@freescale.com>

On 10/27/11 21:11, Scott Wood wrote:
> On 10/27/2011 03:43 AM, Suzuki Poulose wrote:
>> On 10/27/11 00:46, Scott Wood wrote:
>>> On 10/26/2011 02:12 PM, Suzuki Poulose wrote:
>>>> I have renamed the new type of relocation to RELOCATABLE_PPC32_PIE. The
>>>> patches
>>>> were posted yesterday. Please let me know your thoughts.
>>>
>>> I think it would make more sense to rename the existing behavior (maybe
>>> something like DYNAMIC_MEMSTART -- if there's even enough overhead to
>>> make it worth being configurable at all), since it's not fully
>>> relocatable and since 64-bit already uses RELOCATABLE to mean PIE.
>>
>> I think leaving the current behaviour as it is, and adding the PIE as an
>> additional configuration option would be safe and wouldn't disturb the
>> existing dependencies.
>
> That's how things grow to be an unmaintainable mess.  AFAICT, what
> you're doing is the same as what 64-bit does for RELOCATABLE.  If
> they're doing the same thing, they should be called the same thing.
> Whereas 64-bit and e500 are currently doing different things for
> RELOCATABLE -- so they should be called different things.

OK. Agreed. I will resend the patches with the change.

Thanks
Suzuki

  reply	other threads:[~2011-10-28  5:03 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-10-10  9:54 [PATCH 0/3] Kdump support for PPC440x Suzuki K. Poulose
2011-10-10  9:55 ` [PATCH 1/3] [powerpc32] Process dynamic relocations for kernel Suzuki K. Poulose
2011-10-10 15:15   ` Scott Wood
2011-10-10 17:17     ` Suzuki Poulose
2011-10-10 17:55       ` Scott Wood
2011-10-10  9:56 ` [PATCH 2/3] [44x] Enable CONFIG_RELOCATABLE for PPC44x Suzuki K. Poulose
2011-10-10 18:00   ` Scott Wood
2011-10-11 12:54     ` Suzuki Poulose
2011-10-12 14:15       ` Dave Hansen
2011-10-25 15:34         ` Scott Wood
2011-10-26 19:12           ` Suzuki Poulose
2011-10-26 19:16             ` Scott Wood
2011-10-27  8:43               ` Suzuki Poulose
2011-10-27 15:41                 ` Scott Wood
2011-10-28  5:03                   ` Suzuki Poulose [this message]
2011-10-10  9:57 ` [PATCH 3/3] [44x] Enable CRASH_DUMP for 440x Suzuki K. Poulose

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4EAA378D.2080304@in.ibm.com \
    --to=suzuki@in.ibm.com \
    --cc=David.Laight@ACULAB.COM \
    --cc=dave@linux.vnet.ibm.com \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=mahesh@linux.vnet.ibm.com \
    --cc=monstr@monstr.eu \
    --cc=paulus@samba.org \
    --cc=scottwood@freescale.com \
    --cc=tmarri@apm.com \
    --cc=vgoyal@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.