From: Rik van Riel <riel@redhat.com>
To: Gilad Ben-Yossef <gilad@benyossef.com>
Cc: linux-kernel@vger.kernel.org,
Peter Zijlstra <a.p.zijlstra@chello.nl>,
Frederic Weisbecker <fweisbec@gmail.com>,
Russell King <linux@arm.linux.org.uk>,
linux-mm@kvack.org, Christoph Lameter <cl@linux-foundation.org>,
Pekka Enberg <penberg@kernel.org>, Matt Mackall <mpm@selenic.com>,
Sasha Levin <levinsasha928@gmail.com>
Subject: Re: [PATCH v2 4/6] mm: Only IPI CPUs to drain local pages if they exist
Date: Fri, 28 Oct 2011 12:07:45 -0400 [thread overview]
Message-ID: <4EAAD351.70805@redhat.com> (raw)
In-Reply-To: <1319385413-29665-5-git-send-email-gilad@benyossef.com>
On 10/23/2011 11:56 AM, Gilad Ben-Yossef wrote:
> Use a cpumask to track CPUs with per-cpu pages in any zone
> and only send an IPI requesting CPUs to drain these pages
> to the buddy allocator if they actually have pages.
> +/* Which CPUs have per cpu pages */
> +cpumask_var_t cpus_with_pcp;
> +static DEFINE_PER_CPU(unsigned long, total_cpu_pcp_count);
Does the flushing happen so frequently that it is worth keeping this
state on a per-cpu basis, or would it be better to check each CPU's
pcp info and assemble a cpumask at flush time like done in patch 5?
--
All rights reversed
WARNING: multiple messages have this Message-ID (diff)
From: Rik van Riel <riel@redhat.com>
To: Gilad Ben-Yossef <gilad@benyossef.com>
Cc: linux-kernel@vger.kernel.org,
Peter Zijlstra <a.p.zijlstra@chello.nl>,
Frederic Weisbecker <fweisbec@gmail.com>,
Russell King <linux@arm.linux.org.uk>,
linux-mm@kvack.org, Christoph Lameter <cl@linux-foundation.org>,
Pekka Enberg <penberg@kernel.org>, Matt Mackall <mpm@selenic.com>,
Sasha Levin <levinsasha928@gmail.com>
Subject: Re: [PATCH v2 4/6] mm: Only IPI CPUs to drain local pages if they exist
Date: Fri, 28 Oct 2011 12:07:45 -0400 [thread overview]
Message-ID: <4EAAD351.70805@redhat.com> (raw)
In-Reply-To: <1319385413-29665-5-git-send-email-gilad@benyossef.com>
On 10/23/2011 11:56 AM, Gilad Ben-Yossef wrote:
> Use a cpumask to track CPUs with per-cpu pages in any zone
> and only send an IPI requesting CPUs to drain these pages
> to the buddy allocator if they actually have pages.
> +/* Which CPUs have per cpu pages */
> +cpumask_var_t cpus_with_pcp;
> +static DEFINE_PER_CPU(unsigned long, total_cpu_pcp_count);
Does the flushing happen so frequently that it is worth keeping this
state on a per-cpu basis, or would it be better to check each CPU's
pcp info and assemble a cpumask at flush time like done in patch 5?
--
All rights reversed
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2011-10-28 16:08 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-23 15:56 [PATCH v2 0/6] Reduce cross CPU IPI interference Gilad Ben-Yossef
2011-10-23 15:56 ` Gilad Ben-Yossef
2011-10-23 15:56 ` [PATCH v2 1/6] smp: Introduce a generic on_each_cpu_mask function Gilad Ben-Yossef
2011-10-23 15:56 ` Gilad Ben-Yossef
2011-10-23 15:56 ` [PATCH v2 2/6] arm: Move arm over to generic on_each_cpu_mask Gilad Ben-Yossef
2011-10-23 15:56 ` Gilad Ben-Yossef
2011-10-23 15:56 ` [PATCH v2 3/6] tile: Move tile to use " Gilad Ben-Yossef
2011-10-23 15:56 ` Gilad Ben-Yossef
2011-10-23 15:56 ` [PATCH v2 4/6] mm: Only IPI CPUs to drain local pages if they exist Gilad Ben-Yossef
2011-10-23 15:56 ` Gilad Ben-Yossef
2011-10-28 16:07 ` Rik van Riel [this message]
2011-10-28 16:07 ` Rik van Riel
2011-10-29 15:29 ` Gilad Ben-Yossef
2011-10-29 15:29 ` Gilad Ben-Yossef
2011-11-02 8:53 ` Christoph Lameter
2011-11-10 8:03 ` Gilad Ben-Yossef
2011-11-10 8:03 ` Gilad Ben-Yossef
2011-10-23 15:56 ` [PATCH v2 5/6] slub: Only IPI CPUs that have per cpu obj to flush Gilad Ben-Yossef
2011-10-23 15:56 ` Gilad Ben-Yossef
2011-10-28 4:06 ` Christoph Lameter
2011-10-28 4:06 ` Christoph Lameter
2011-10-28 8:50 ` Gilad Ben-Yossef
2011-10-28 8:50 ` Gilad Ben-Yossef
2011-10-23 15:56 ` [PATCH v2 6/6] slub: only preallocate cpus_with_slabs if offstack Gilad Ben-Yossef
2011-10-23 15:56 ` Gilad Ben-Yossef
2011-10-28 4:06 ` Christoph Lameter
2011-10-28 4:06 ` Christoph Lameter
2011-10-28 9:09 ` Gilad Ben-Yossef
2011-10-28 9:09 ` Gilad Ben-Yossef
2011-11-02 8:52 ` Christoph Lameter
2011-11-02 8:52 ` Christoph Lameter
2011-11-06 19:10 ` Pekka Enberg
2011-11-06 19:10 ` Pekka Enberg
2011-11-13 8:39 ` Gilad Ben-Yossef
2011-11-13 8:39 ` Gilad Ben-Yossef
-- strict thread matches above, loose matches on Subject: below --
2011-10-23 15:48 [PATCH v2 0/6] Reduce cross CPU IPI interference Gilad Ben-Yossef
2011-10-23 15:48 ` [PATCH v2 4/6] mm: Only IPI CPUs to drain local pages if they exist Gilad Ben-Yossef
2011-10-28 4:10 ` Christoph Lameter
2011-10-28 8:42 ` Gilad Ben-Yossef
2011-10-28 8:43 ` Gilad Ben-Yossef
2011-10-28 8:43 ` Gilad Ben-Yossef
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4EAAD351.70805@redhat.com \
--to=riel@redhat.com \
--cc=a.p.zijlstra@chello.nl \
--cc=cl@linux-foundation.org \
--cc=fweisbec@gmail.com \
--cc=gilad@benyossef.com \
--cc=levinsasha928@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux@arm.linux.org.uk \
--cc=mpm@selenic.com \
--cc=penberg@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.