diff for duplicates of <4EAB6495.40707@gmail.com> diff --git a/a/1.txt b/N1/1.txt index 0e5b21b..f74b634 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -14,9 +14,9 @@ On 29/10/11 10:58, Julia Lawall wrote: > statement S1,S2,S3; > @@ > -> if (E = NULL) +> if (E == NULL) > { -> ... when != if (E = NULL || ...) S1 else S2 +> ... when != if (E == NULL || ...) S1 else S2 > when != E = E1 > *E->f > ... when any @@ -40,7 +40,7 @@ On 29/10/11 10:58, Julia Lawall wrote: If di is null, we've already failed as it's dereferenced here. -> if (di = NULL) { +> if (di == NULL) { > - DMA_ERROR(("%s: _dma_ctrlflags: NULL dma handle\n", di->name)); > + DMA_ERROR(("_dma_ctrlflags: NULL dma handle\n")); > return 0; @@ -76,7 +76,7 @@ index b56a302..6ebec8f 100644 - uint dmactrlflags = di->dma.dmactrlflags; + uint dmactrlflags; - if (di = NULL) { + if (di == NULL) { - DMA_ERROR(("%s: _dma_ctrlflags: NULL dma handle\n", di->name)); + DMA_ERROR(("_dma_ctrlflags: NULL dma handle\n")); return 0; diff --git a/a/content_digest b/N1/content_digest index 76cf695..30d8cd3 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -1,7 +1,7 @@ "ref\01319846297-2985-2-git-send-email-julia@diku.dk\0" "From\0Julian Calaby <julian.calaby@gmail.com>\0" - "Subject\0Re: [PATCH 2/5] drivers/net/wireless/brcm80211/brcmsmac/dma.c: eliminate\0" - "Date\0Sat, 29 Oct 2011 02:27:33 +0000\0" + "Subject\0Re: [PATCH 2/5] drivers/net/wireless/brcm80211/brcmsmac/dma.c: eliminate a null pointer dereference\0" + "Date\0Sat, 29 Oct 2011 13:27:33 +1100\0" "To\0Julia Lawall <julia@diku.dk>\0" "Cc\0John W. Linville <linville@tuxdriver.com>" kernel-janitors@vger.kernel.org @@ -26,9 +26,9 @@ "> statement S1,S2,S3;\n" "> @@\n" "> \n" - "> if (E = NULL)\n" + "> if (E == NULL)\n" "> {\n" - "> ... when != if (E = NULL || ...) S1 else S2\n" + "> ... when != if (E == NULL || ...) S1 else S2\n" "> when != E = E1\n" "> *E->f\n" "> ... when any\n" @@ -52,7 +52,7 @@ "\n" "If di is null, we've already failed as it's dereferenced here.\n" "\n" - "> \tif (di = NULL) {\n" + "> \tif (di == NULL) {\n" "> -\t\tDMA_ERROR((\"%s: _dma_ctrlflags: NULL dma handle\\n\", di->name));\n" "> +\t\tDMA_ERROR((\"_dma_ctrlflags: NULL dma handle\\n\"));\n" "> \t\treturn 0;\n" @@ -88,7 +88,7 @@ "- uint dmactrlflags = di->dma.dmactrlflags;\n" "+ uint dmactrlflags;\n" " \n" - " if (di = NULL) {\n" + " if (di == NULL) {\n" "- DMA_ERROR((\"%s: _dma_ctrlflags: NULL dma handle\\n\", di->name));\n" "+ DMA_ERROR((\"_dma_ctrlflags: NULL dma handle\\n\"));\n" " return 0;\n" @@ -109,4 +109,4 @@ "Profile: http://www.google.com/profiles/julian.calaby/\n" .Plan: http://sites.google.com/site/juliancalaby -c01e90cadfe1982ef067ae863e58e2f4c94d6037acca0bfbd77383997ddf9414 +313df69818ed0650a4b874baf5a6b876781417bda73bf4880ac5e726d9ce0d31
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.