Re: femon patch for dB

[Mauro Carvalho Chehab <mchehab@redhat.com>]

Em 29-10-2011 07:39, Randy Dunlap escreveu:
> On 10/28/11 22:12, James wrote:
>> diff -r d4e8bf5658ce util/femon/femon.c
>> --- a/util/femon/femon.c    Fri Oct 07 01:26:04 2011 +0530
>> +++ b/util/femon/femon.c    Fri Oct 28 18:52:12 2011 -0400
>> @@ -16,6 +16,9 @@
>>   * You should have received a copy of the GNU General Public License
>>   * along with this program; if not, write to the Free Software
>>   * Foundation, Inc., 675 Mass Ave, Cambridge, MA 02139, USA.
>> + *
>> + * James Lockie: Oct. 2011
>> + * modified to add a switch (-2) to show signal/snr in dB
>>   */
>>  
>>  
>> @@ -37,11 +40,16 @@
>>  
>>  #include <libdvbapi/dvbfe.h>
>>  
>> +/* the s5h1409 delivers both fields in 0.1dB increments, while
>> + * some demods expect signal to be 0-65535 and SNR to be in 1/256
>> increments
> 
> Looks like thunderbird is being too helpful for us here -- by breaking
> a long line where it shouldn't be broken.  You can see if
> <kernel source>/Documentation/email-clients.txt helps you any with that.

This is not a kernel patch, but yes, you're right: there's nothing we can't
apply it to dvb-apps as-is.

Thunderbird only works well if the html editor is disabled and if the max number
of lines is set to 0. I use it here, but I'm currently sending patches directly
from git, as it is simpler, if the smtp server is properly configured.
There is one plugin for it that fixes those stuff on thunerbird (asalted-patches),
but this doesn't work with newer versions of it (well, fixing it is probably
a one-line patch like [2] changing the maxVersion).

[1] https://hg.mozilla.org/users/clarkbw_gnome.org/asalted-patches/
[2] https://hg.mozilla.org/users/clarkbw_gnome.org/asalted-patches/rev/49d587f60371

Regards,
Mauro