diff for duplicates of <4EABC757.7080505@broadcom.com> diff --git a/a/1.txt b/N1/1.txt index 3306c70..08b2c22 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -15,9 +15,9 @@ On 10/29/2011 04:27 AM, Julian Calaby wrote: >> statement S1,S2,S3; >> @@ >> ->> if (E = NULL) +>> if (E == NULL) >> { ->> ... when != if (E = NULL || ...) S1 else S2 +>> ... when != if (E == NULL || ...) S1 else S2 >> when != E = E1 >> *E->f >> ... when any @@ -41,7 +41,7 @@ On 10/29/2011 04:27 AM, Julian Calaby wrote: > > If di is null, we've already failed as it's dereferenced here. > ->> if (di = NULL) { +>> if (di == NULL) { >> - DMA_ERROR(("%s: _dma_ctrlflags: NULL dma handle\n", di->name)); >> + DMA_ERROR(("_dma_ctrlflags: NULL dma handle\n")); >> return 0; @@ -77,7 +77,7 @@ On 10/29/2011 04:27 AM, Julian Calaby wrote: > - uint dmactrlflags = di->dma.dmactrlflags; > + uint dmactrlflags; > -> if (di = NULL) { +> if (di == NULL) { > - DMA_ERROR(("%s: _dma_ctrlflags: NULL dma handle\n", di->name)); > + DMA_ERROR(("_dma_ctrlflags: NULL dma handle\n")); > return 0; diff --git a/a/content_digest b/N1/content_digest index 9266fb3..55fd5b2 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -1,8 +1,8 @@ "ref\01319846297-2985-2-git-send-email-julia@diku.dk\0" "ref\04EAB6495.40707@gmail.com\0" "From\0Arend van Spriel <arend@broadcom.com>\0" - "Subject\0Re: [PATCH 2/5] drivers/net/wireless/brcm80211/brcmsmac/dma.c:\0" - "Date\0Sat, 29 Oct 2011 09:28:55 +0000\0" + "Subject\0Re: [PATCH 2/5] drivers/net/wireless/brcm80211/brcmsmac/dma.c: eliminate a null pointer dereference\0" + "Date\0Sat, 29 Oct 2011 11:28:55 +0200\0" "To\0Julian Calaby <julian.calaby@gmail.com>\0" "Cc\0Julia Lawall <julia@diku.dk>" John W. Linville <linville@tuxdriver.com> @@ -29,9 +29,9 @@ ">> statement S1,S2,S3;\n" ">> @@\n" ">>\n" - ">> if (E = NULL)\n" + ">> if (E == NULL)\n" ">> {\n" - ">> ... when != if (E = NULL || ...) S1 else S2\n" + ">> ... when != if (E == NULL || ...) S1 else S2\n" ">> when != E = E1\n" ">> *E->f\n" ">> ... when any\n" @@ -55,7 +55,7 @@ "> \n" "> If di is null, we've already failed as it's dereferenced here.\n" "> \n" - ">> \tif (di = NULL) {\n" + ">> \tif (di == NULL) {\n" ">> -\t\tDMA_ERROR((\"%s: _dma_ctrlflags: NULL dma handle\\n\", di->name));\n" ">> +\t\tDMA_ERROR((\"_dma_ctrlflags: NULL dma handle\\n\"));\n" ">> \t\treturn 0;\n" @@ -91,7 +91,7 @@ "> - uint dmactrlflags = di->dma.dmactrlflags;\n" "> + uint dmactrlflags;\n" "> \n" - "> if (di = NULL) {\n" + "> if (di == NULL) {\n" "> - DMA_ERROR((\"%s: _dma_ctrlflags: NULL dma handle\\n\", di->name));\n" "> + DMA_ERROR((\"_dma_ctrlflags: NULL dma handle\\n\"));\n" "> return 0;\n" @@ -115,4 +115,4 @@ "\n" Gr. AvS -57b316ff6ce3b2d3e9c0aaf05644f67f9c975c4e47a1aba547b5c17450fef91d +5b6601a8ce1000019066de751a2ab58b8246f08e9ad8d04d817f0b691f0bfef8
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.