From: Marco Stornelli <marco.stornelli@gmail.com>
To: Bryan Freed <bfreed@chromium.org>
Cc: linux-kernel@vger.kernel.org, sergiu@chromium.org,
akpm@linux-foundation.org, msb@chromium.org,
seiji.aguchi@hds.com
Subject: Re: [PATCH] ramoops appears geared to not support ARM
Date: Sat, 29 Oct 2011 16:22:16 +0200 [thread overview]
Message-ID: <4EAC0C18.5090602@gmail.com> (raw)
In-Reply-To: <1319844110-23062-1-git-send-email-bfreed@chromium.org>
Il 29/10/2011 01:21, Bryan Freed ha scritto:
> I had some difficulty in getting ramoops to work on our ARM systems.
> The driver maps memory with ioremap() which is supposed to map IO memory,
> not physical RAM. This happens to work on x86 and apparently some other
> architectures, but it does not work on ARM.
> Specifically, I see this comment in __arm_ioremap_pfn_caller():
> Don't allow RAM to be mapped - this causes problems with ARMv6+
>
> So here is a patch that hacks around the issue using page_is_ram() to
> differentiate between the two.
>
> Am I missing something here?
> Is ramoops working on any ARM systems yet, and I am just doing something wrong?
>
> My ARM platform reserves a section of RAM for use by ramoops, but it is still
> mapped along with the rest of main memory. This is so /dev/mem can find it
> with xlate_dev_mem_ptr().
> On x86, I see our BIOS reserves the memory so that it is not counted as main
> memory, and it is not mapped until ramoops ioremaps it.
>
> Bryan Freed (1):
> ramoops: Add support for ARM systems.
>
> drivers/char/ramoops.c | 67 +++++++++++++++++++++++++++++++++++++----------
> 1 files changed, 52 insertions(+), 15 deletions(-)
>
Bryan,
I think the right thing to do here, it's to reserve in right way the
piece of RAM you use according to your arch (see the Russell response).
Marco
next prev parent reply other threads:[~2011-10-29 14:28 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-28 23:21 [PATCH] ramoops appears geared to not support ARM Bryan Freed
2011-10-28 23:21 ` [PATCH] ramoops: Add support for ARM systems Bryan Freed
2011-10-29 8:39 ` [PATCH] ramoops appears geared to not support ARM Marco Stornelli
2011-10-29 8:39 ` Marco Stornelli
2011-10-29 9:34 ` Russell King - ARM Linux
2011-10-29 9:34 ` Russell King - ARM Linux
2011-10-29 11:04 ` Marco Stornelli
2011-10-29 11:04 ` Marco Stornelli
2011-10-29 11:55 ` Russell King - ARM Linux
2011-10-29 11:55 ` Russell King - ARM Linux
2011-10-29 12:42 ` Marco Stornelli
2011-10-29 12:42 ` Marco Stornelli
2011-10-29 12:53 ` Russell King - ARM Linux
2011-10-29 12:53 ` Russell King - ARM Linux
2011-10-29 14:22 ` Marco Stornelli [this message]
[not found] ` <CAEYUcX1PUgniJLqYXKM5pf_9T06OPFg4q0ZUCFc8Deu1J_R9-A@mail.gmail.com>
2011-10-30 11:33 ` Marco Stornelli
2011-10-31 6:03 ` Bryan Freed
2011-10-31 8:57 ` Marco Stornelli
2011-10-31 23:03 ` Bryan Freed
2011-11-01 8:52 ` Marco Stornelli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4EAC0C18.5090602@gmail.com \
--to=marco.stornelli@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=bfreed@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=msb@chromium.org \
--cc=seiji.aguchi@hds.com \
--cc=sergiu@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.