From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1RKM5w-0002pf-C6 for mharc-grub-devel@gnu.org; Sat, 29 Oct 2011 23:30:00 -0400 Received: from eggs.gnu.org ([140.186.70.92]:55871) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RKM5u-0002p0-2V for grub-devel@gnu.org; Sat, 29 Oct 2011 23:29:59 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RKM5s-0007LY-O8 for grub-devel@gnu.org; Sat, 29 Oct 2011 23:29:57 -0400 Received: from mail-fx0-f41.google.com ([209.85.161.41]:57983) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RKM5s-0007LT-Ai for grub-devel@gnu.org; Sat, 29 Oct 2011 23:29:56 -0400 Received: by faat2 with SMTP id t2so2590739faa.0 for ; Sat, 29 Oct 2011 20:29:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=message-id:date:from:user-agent:mime-version:to:subject:references :in-reply-to:x-enigmail-version:content-type; bh=44DWAh/ADVQ2pSKjD0Qu4lwTfAkt3p6SJfM/7NNXpb4=; b=Oa7cwzgGrOYUGcBcID8d8+2ng5CryeREKhrykH8+62kmzbKibGQWtfGICD1xr4zj7N AsCH3hfFml/QKKDMJjOZdQAfMen59BbfFFunhv2JCsYAQ0kXf+1TWEB5hJ+wNid7EC6c hRc6WPV67EkT0G3jhvaeIa12+xl7sIxc7Yi3k= Received: by 10.223.75.25 with SMTP id w25mr18909150faj.15.1319945395116; Sat, 29 Oct 2011 20:29:55 -0700 (PDT) Received: from debian.x201.phnet (30-85.203-62.cust.bluewin.ch. [62.203.85.30]) by mx.google.com with ESMTPS id p14sm28414049faf.20.2011.10.29.20.29.51 (version=TLSv1/SSLv3 cipher=OTHER); Sat, 29 Oct 2011 20:29:52 -0700 (PDT) Message-ID: <4EACC4AE.5030504@gmail.com> Date: Sun, 30 Oct 2011 04:29:50 +0100 From: =?UTF-8?B?VmxhZGltaXIgJ8+GLWNvZGVyL3BoY29kZXInIFNlcmJpbmVua28=?= User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.23) Gecko/20111005 Iceowl/1.0b2 Icedove/3.1.15 MIME-Version: 1.0 To: grub-devel@gnu.org Subject: Re: [bug] Wrong machtype argument passed for fuloong-2f References: <87y5w4f8bj.fsf@snail.Pool> <20111029103758.GM4110@mails.so.argh.org> <87ipn7frvv.fsf@snail.Pool> <20111029205434.GQ4110@mails.so.argh.org> In-Reply-To: <20111029205434.GQ4110@mails.so.argh.org> X-Enigmail-Version: 1.1.2 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="------------enig538B52FC2708DFBFB34C67DD" X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-Received-From: 209.85.161.41 X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list Reply-To: The development of GNU GRUB List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 30 Oct 2011 03:29:59 -0000 This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enig538B52FC2708DFBFB34C67DD Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 29.10.2011 22:54, Andreas Barth wrote: > * David Kuehling (dvdkhlng@gmx.de) [111029 22:46]: >> BTW it looks like it is impossible to override machtype=3D parameter f= rom >> the kernel command line configured in boot/grub/grub.cfg, since linux >> code in loongson/common/machtype.c uses the first occurence of >> "machtype=3D" in arcs_cmdline[]. Is this behaviour by design or by >> accident? Is this linux' fault or grub's fault? One could change gru= b >> to append machtype=3D rather than prepend it to the command line... > I would consider it more appropriate to add a flag "suppress pmon > command line" to the grub configuration - if you want to overwrite it, > it should fully disappear, and not just be not parsed because there is > another one first. > As I already said: machtype isn't only about pmon. And I consider it as part of protocol on loongson so no, it won't be overrideable. Moreover it's fundamentally wrong to make bugs configurable (bugs=3Don). Please tr= y the following patch: =3D=3D=3D modified file 'grub-core/loader/mips/linux.c' --- grub-core/loader/mips/linux.c 2011-08-19 20:46:11 +0000 +++ grub-core/loader/mips/linux.c 2011-10-30 03:28:36 +0000 @@ -41,7 +41,7 @@ const char loongson_machtypes[][60] =3D { [GRUB_ARCH_MACHINE_YEELOONG] =3D "machtype=3Dlemote-yeeloong-2f-8.9i= nches", - [GRUB_ARCH_MACHINE_FULOONG2F] =3D "machtype=3Dlemote-fuloong-2f-unk= nown", + [GRUB_ARCH_MACHINE_FULOONG2F] =3D "machtype=3Dlemote-fuloong-2f-box= ", [GRUB_ARCH_MACHINE_FULOONG2E] =3D "machtype=3Dlemote-fuloong-2e-unk= nown" }; #endif =20 > Andi > > _______________________________________________ > Grub-devel mailing list > Grub-devel@gnu.org > https://lists.gnu.org/mailman/listinfo/grub-devel > --=20 Regards Vladimir '=CF=86-coder/phcoder' Serbinenko --------------enig538B52FC2708DFBFB34C67DD Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.11 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iF4EAREKAAYFAk6sxK4ACgkQNak7dOguQgn3VQEAvyTi7zpxKiXwABeEUgj2hR6o /X84YsIW/sVfdzcB+f8A/3BE33lmjuskjxTw0683abDT7pEePgX7njs4rMQRFvyD =uo5z -----END PGP SIGNATURE----- --------------enig538B52FC2708DFBFB34C67DD--