From: Denis Kenzior <denkenz@gmail.com>
To: ofono@ofono.org
Subject: Re: [PATCH 2/2] cdma-connman: Add cdma-netreg status watch to activate data call
Date: Sun, 30 Oct 2011 03:27:09 -0500 [thread overview]
Message-ID: <4EAD0A5D.80008@gmail.com> (raw)
In-Reply-To: <4EAEBE5F.7080208@linux.intel.com>
[-- Attachment #1: Type: text/plain, Size: 1278 bytes --]
Hi Guillaume,
>> There is no concept of attachment in CDMA, so I'd prefer we not do it
>> this way. Can't we simply check the current netreg atom status here?
>
> Fine for me. Then we should also create a new D-Bus error message like:
> __ofono_error_not_registered().
>
That sounds fine to me.
<snip>
>> It seems to me that this is way too complicated. All you want is to
>> check the netreg status before trying to set powered. If we lose netreg
>> when the connection is active, then the regular cdma-connman
>> notification procedures would apply.
>
> Once we lost netreg, what are we supposed to do?
> cdma-netreg atom will signal "Status" property has changed.
> Is that up to ConnMan to deactivate the data call in checking the
> cdma-netreg "Status" property equal to "unregistered"?
Ah, so that's what you want to accomplish. This wasn't clear from your
patch. You have two options here:
- Rely on the modem to drop the data connection and have the
cdma-connman driver notify us appropriately. The mechanism would be
similar to ofono_gprs_context_deactivated.
- In addition to above, force the Powered property to False when the
registration is lost. In which case you would need the status watches.
Regards,
-Denis
prev parent reply other threads:[~2011-10-30 8:27 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-20 15:41 [PATCH 0/2] CDMA network registration Guillaume Zajac
2011-10-20 15:41 ` [PATCH 1/2] cdma-netreg: Add various cdma-netreg watches Guillaume Zajac
2011-10-30 7:18 ` Denis Kenzior
2011-10-31 14:55 ` Guillaume Zajac
2011-10-20 15:41 ` [PATCH 2/2] cdma-connman: Add cdma-netreg status watch to activate data call Guillaume Zajac
2011-10-30 7:16 ` Denis Kenzior
2011-10-31 15:27 ` Guillaume Zajac
2011-10-30 8:27 ` Denis Kenzior [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4EAD0A5D.80008@gmail.com \
--to=denkenz@gmail.com \
--cc=ofono@ofono.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.