From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kenji Kaneshige Subject: Re: [Qemu-devel] [PATCH 1/2] seabios: Add Local APIC NMI Structure to ACPI MADT Date: Mon, 31 Oct 2011 17:00:52 +0900 Message-ID: <4EAE55B4.30604@jp.fujitsu.com> References: <20110913093835.GB4265@localhost.localdomain> <20110914093441.e2bb305c.kamezawa.hiroyu@jp.fujitsu.com> <4E705BC3.5000508@cn.fujitsu.com> <20110915164704.9cacd407.kamezawa.hiroyu@jp.fujitsu.com> <4E71B28F.7030201@cn.fujitsu.com> <4E72F3BA.2000603@jp.fujitsu.com> <4E73200A.7040908@jp.fujitsu.com> <4E76C6AA.9080403@cn.fujitsu.com> <4E7B04DC.1030407@cn.fujitsu.com> <4E7B4B8F.507@siemens.com> <4E7C51E4.2000503@cn.fujitsu.com> <4E7F3585.40108@redhat.com> <4E7F635E.6080009@web.de> <4E8035F9.9080908@redhat.com> <4E928B59.2060906@cn.fujitsu.com> <4EAA9B32.10706@jp.fujitsu.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: Avi Kivity , Jan Kiszka , Lai Jiangshan , "kvm@vger.kernel.org" , seabios@seabios.org, "qemu-devel@nongnu.org" , gleb@redhat.com, kevin@koconnor.net, KAMEZAWA Hiroyuki To: Jun Koi Return-path: Received: from fgwmail6.fujitsu.co.jp ([192.51.44.36]:55126 "EHLO fgwmail6.fujitsu.co.jp" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754321Ab1JaIBW (ORCPT ); Mon, 31 Oct 2011 04:01:22 -0400 Received: from m1.gw.fujitsu.co.jp (unknown [10.0.50.71]) by fgwmail6.fujitsu.co.jp (Postfix) with ESMTP id 8A0143EE0BC for ; Mon, 31 Oct 2011 17:01:20 +0900 (JST) Received: from smail (m1 [127.0.0.1]) by outgoing.m1.gw.fujitsu.co.jp (Postfix) with ESMTP id 5FFE445DE9A for ; Mon, 31 Oct 2011 17:01:20 +0900 (JST) Received: from s1.gw.fujitsu.co.jp (s1.gw.fujitsu.co.jp [10.0.50.91]) by m1.gw.fujitsu.co.jp (Postfix) with ESMTP id 42E6945DE53 for ; Mon, 31 Oct 2011 17:01:20 +0900 (JST) Received: from s1.gw.fujitsu.co.jp (localhost.localdomain [127.0.0.1]) by s1.gw.fujitsu.co.jp (Postfix) with ESMTP id 234E41DB8056 for ; Mon, 31 Oct 2011 17:01:20 +0900 (JST) Received: from ml14.s.css.fujitsu.com (ml14.s.css.fujitsu.com [10.240.81.134]) by s1.gw.fujitsu.co.jp (Postfix) with ESMTP id B6DCC1DB8052 for ; Mon, 31 Oct 2011 17:01:19 +0900 (JST) In-Reply-To: Sender: kvm-owner@vger.kernel.org List-ID: (2011/10/28 21:48), Jun Koi wrote: > 2011/10/28 Kenji Kaneshige: >> Avi, Jan, >> >> Could you comment on these patches? >> >> Inject-NMI doesn't work on Windows guest without these patches. > > sorry but i am really curious here: why Windows still works well even > if it desnt see the inject-NMI? > or there are still invisible side-effects that we are not awere of??? Without this patch, LVT LINT1 is not configured by Windows guest because seabios MADT has no ACPI NMI structure which is used by Windows to setup LVT. So NMI interrupt would not be sent to CPUs when NMI signal happens on LINT1. But qemu/kvm inject-nmi feature had a bug that it sent NMI to CPUs without emulating LAPIC LVT. As a result, NMI interrupt is sent to all the CPUs even though LVT LINT1 is not configured. This is why inject-nmi behaves as if it works well on Windows guest. Regards, Kenji Kaneshige From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:54124) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RKmoB-0008Ox-Ad for qemu-devel@nongnu.org; Mon, 31 Oct 2011 04:01:28 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RKmoA-0001nE-1D for qemu-devel@nongnu.org; Mon, 31 Oct 2011 04:01:27 -0400 Received: from fgwmail6.fujitsu.co.jp ([192.51.44.36]:48592) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RKmo9-0001n5-DZ for qemu-devel@nongnu.org; Mon, 31 Oct 2011 04:01:25 -0400 Received: from m3.gw.fujitsu.co.jp (unknown [10.0.50.73]) by fgwmail6.fujitsu.co.jp (Postfix) with ESMTP id 408CC3EE0AE for ; Mon, 31 Oct 2011 17:01:20 +0900 (JST) Received: from smail (m3 [127.0.0.1]) by outgoing.m3.gw.fujitsu.co.jp (Postfix) with ESMTP id 25CEC45DEB3 for ; Mon, 31 Oct 2011 17:01:20 +0900 (JST) Received: from s3.gw.fujitsu.co.jp (s3.gw.fujitsu.co.jp [10.0.50.93]) by m3.gw.fujitsu.co.jp (Postfix) with ESMTP id 0A49E45DE7E for ; Mon, 31 Oct 2011 17:01:20 +0900 (JST) Received: from s3.gw.fujitsu.co.jp (localhost.localdomain [127.0.0.1]) by s3.gw.fujitsu.co.jp (Postfix) with ESMTP id EFEB61DB8038 for ; Mon, 31 Oct 2011 17:01:19 +0900 (JST) Received: from ml14.s.css.fujitsu.com (ml14.s.css.fujitsu.com [10.240.81.134]) by s3.gw.fujitsu.co.jp (Postfix) with ESMTP id B4FAF1DB803C for ; Mon, 31 Oct 2011 17:01:19 +0900 (JST) Message-ID: <4EAE55B4.30604@jp.fujitsu.com> Date: Mon, 31 Oct 2011 17:00:52 +0900 From: Kenji Kaneshige MIME-Version: 1.0 References: <20110913093835.GB4265@localhost.localdomain> <20110914093441.e2bb305c.kamezawa.hiroyu@jp.fujitsu.com> <4E705BC3.5000508@cn.fujitsu.com> <20110915164704.9cacd407.kamezawa.hiroyu@jp.fujitsu.com> <4E71B28F.7030201@cn.fujitsu.com> <4E72F3BA.2000603@jp.fujitsu.com> <4E73200A.7040908@jp.fujitsu.com> <4E76C6AA.9080403@cn.fujitsu.com> <4E7B04DC.1030407@cn.fujitsu.com> <4E7B4B8F.507@siemens.com> <4E7C51E4.2000503@cn.fujitsu.com> <4E7F3585.40108@redhat.com> <4E7F635E.6080009@web.de> <4E8035F9.9080908@redhat.com> <4E928B59.2060906@cn.fujitsu.com> <4EAA9B32.10706@jp.fujitsu.com> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 1/2] seabios: Add Local APIC NMI Structure to ACPI MADT List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Jun Koi Cc: Lai Jiangshan , "kvm@vger.kernel.org" , seabios@seabios.org, "qemu-devel@nongnu.org" , gleb@redhat.com, kevin@koconnor.net, Jan Kiszka , Avi Kivity , KAMEZAWA Hiroyuki (2011/10/28 21:48), Jun Koi wrote: > 2011/10/28 Kenji Kaneshige: >> Avi, Jan, >> >> Could you comment on these patches? >> >> Inject-NMI doesn't work on Windows guest without these patches. > > sorry but i am really curious here: why Windows still works well even > if it desnt see the inject-NMI? > or there are still invisible side-effects that we are not awere of??? Without this patch, LVT LINT1 is not configured by Windows guest because seabios MADT has no ACPI NMI structure which is used by Windows to setup LVT. So NMI interrupt would not be sent to CPUs when NMI signal happens on LINT1. But qemu/kvm inject-nmi feature had a bug that it sent NMI to CPUs without emulating LAPIC LVT. As a result, NMI interrupt is sent to all the CPUs even though LVT LINT1 is not configured. This is why inject-nmi behaves as if it works well on Windows guest. Regards, Kenji Kaneshige