From: Kevin Wolf <kwolf@redhat.com>
To: Zhi Yong Wu <wuzhy@linux.vnet.ibm.com>
Cc: qemu-devel@nongnu.org, stefanha@linux.vnet.ibm.com
Subject: Re: [Qemu-devel] [PATCH] qed: adjust the way to get nb_sectors
Date: Mon, 31 Oct 2011 09:10:07 +0100 [thread overview]
Message-ID: <4EAE57DF.9080602@redhat.com> (raw)
In-Reply-To: <1320030109-20476-1-git-send-email-wuzhy@linux.vnet.ibm.com>
Am 31.10.2011 04:01, schrieb Zhi Yong Wu:
> It is better to use qiov.size in qed-table.c to get nb_sectors than iov.iov_len.
>
> Signed-off-by: Zhi Yong Wu <wuzhy@linux.vnet.ibm.com>
The commit message should probably say why it's better. Not saying
otherwise, but I can't see the different at the first sight.
Kevin
next prev parent reply other threads:[~2011-10-31 8:07 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-31 3:01 [Qemu-devel] [PATCH] qed: adjust the way to get nb_sectors Zhi Yong Wu
2011-10-31 8:10 ` Kevin Wolf [this message]
2011-10-31 8:25 ` Zhi Yong Wu
2011-10-31 14:11 ` Stefan Hajnoczi
2011-11-01 1:54 ` Zhi Yong Wu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4EAE57DF.9080602@redhat.com \
--to=kwolf@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@linux.vnet.ibm.com \
--cc=wuzhy@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.