From: RONETIX - Asen Dimov <dimov@ronetix.at>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] pm9261: add mach-type localy for the board
Date: Mon, 31 Oct 2011 11:04:02 +0200 [thread overview]
Message-ID: <4EAE6482.80607@ronetix.at> (raw)
In-Reply-To: <4EAAF1B2.4080701@aribaud.net>
Hi Albert,
On 10/28/2011 09:17 PM, Albert ARIBAUD wrote:
> Hi Asen,
>
> You should copy Ilko as the maintainer, unless you are taking over
> maintainership of this board (and pm9263 and pm9g45), in which case
> please modify MAINTAINERS file as well.
Ok, I will CC: him next time.
>
> Le 28/10/2011 18:10, Asen Chavdarov Dimov a ?crit :
>> Signed-off-by: Asen Chavdarov Dimov<dimov@ronetix.at>
>> ---
>> board/ronetix/pm9261/mach-type.h | 31
>> +++++++++++++++++++++++++++++++
>
> NAK. Do not copy-paste mach-type.h, just add the MACH_TYPE_PM9261
> define in include/configs/pm9261.h.
>
>> board/ronetix/pm9261/pm9261.c | 1 +
>> 2 files changed, 32 insertions(+), 0 deletions(-)
>> create mode 100644 board/ronetix/pm9261/mach-type.h
...
>> #include<common.h>
>> +#include "mach-type.h"
>
> NAK -- you don't need this if you add MACH_TYPE_PM9261.
>
>> #include<asm/sizes.h>
>> #include<asm/io.h>
>> #include<asm/arch/at91sam9_smc.h>
>
> Same applies to the other two boards -- you can actually submit a
> single patch for all three of them.
>
Ok.
> Amicalement,
Regards,
Asen
prev parent reply other threads:[~2011-10-31 9:04 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-28 16:10 [U-Boot] [PATCH] pm9261: add mach-type localy for the board Asen Chavdarov Dimov
2011-10-28 18:17 ` Albert ARIBAUD
2011-10-31 8:46 ` Igor Grinberg
2011-10-31 9:04 ` RONETIX - Asen Dimov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4EAE6482.80607@ronetix.at \
--to=dimov@ronetix.at \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.