From: Jaehoon Chung <jh80.chung@samsung.com>
To: Jaehoon Chung <jh80.chung@samsung.com>
Cc: linux-mmc <linux-mmc@vger.kernel.org>,
Chris Ball <cjb@laptop.org>,
Kyungmin Park <kyungmin.park@samsung.com>,
paul@pwsan.com
Subject: Re: [PATCH] mmc: core: fix the critical bug for multiple block read
Date: Mon, 31 Oct 2011 19:52:07 +0900 [thread overview]
Message-ID: <4EAE7DD7.6090304@samsung.com> (raw)
In-Reply-To: <4EAE7C76.1050104@samsung.com>
Sorry card->host->caps instead of host->mmc->caps.(typo)
On 10/31/2011 07:46 PM, Jaehoon Chung wrote:
> This patch is fixed the critical bug for multiple block read.
>
> In Paul's patch(commit:6d621423128909f09072835445ce36dd357a758a),
> used MMC_CAP2_NO_MULTI_READ. But that value was assigned card->host->caps.
>
> MMC_CAPS2_NO_MULTI_READ must assign card->host->caps2 instead of card->host->caps.
>
> Signed-off-by: Jaehoon Chung <jh80.chung@samsung.com>
> Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>
> ---
> drivers/mmc/card/block.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/mmc/card/block.c b/drivers/mmc/card/block.c
> index 4fd5723..1882149 100644
> --- a/drivers/mmc/card/block.c
> +++ b/drivers/mmc/card/block.c
> @@ -1037,7 +1037,7 @@ static void mmc_blk_rw_rq_prep(struct mmc_queue_req *mqrq,
> brq->data.blocks = 1;
>
> /* Some controllers can't do multiblock reads due to hw bugs */
> - if (card->host->caps & MMC_CAP2_NO_MULTI_READ &&
> + if (card->host->caps2 & MMC_CAP2_NO_MULTI_READ &&
> rq_data_dir(req) == READ)
> brq->data.blocks = 1;
> }
> --
> To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
next prev parent reply other threads:[~2011-10-31 10:52 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-31 10:46 [PATCH] mmc: core: fix the critical bug for multiple block read Jaehoon Chung
2011-10-31 10:52 ` Jaehoon Chung [this message]
2011-11-01 9:49 ` Chris Ball
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4EAE7DD7.6090304@samsung.com \
--to=jh80.chung@samsung.com \
--cc=cjb@laptop.org \
--cc=kyungmin.park@samsung.com \
--cc=linux-mmc@vger.kernel.org \
--cc=paul@pwsan.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.