From: Jonathan Cameron <jic23@cam.ac.uk>
To: Lars-Peter Clausen <lars@metafoo.de>
Cc: Michael Hennerich <michael.hennerich@analog.com>,
linux-iio@vger.kernel.org,
device-drivers-devel@blackfin.uclinux.org, drivers@analog.com
Subject: Re: [PATCH] staging:iio:dac:ad5446: Add support for the AD5662
Date: Mon, 31 Oct 2011 11:26:14 +0000 [thread overview]
Message-ID: <4EAE85D6.8090206@cam.ac.uk> (raw)
In-Reply-To: <1319792721-27108-1-git-send-email-lars@metafoo.de>
On 10/28/11 10:05, Lars-Peter Clausen wrote:
> The AD5662 is compatible to the AD5660, but uses an external reference instead
> of an internal.
Trivial, so you could have sent this on whilst I was away. Guess there
was no real rush though!
>
> Signed-off-by: Lars-Peter Clausen <lars@metafoo.de>
Acked-by: Jonathan Cameron <jic23@cam.ac.uk>
> ---
> drivers/staging/iio/dac/Kconfig | 2 +-
> drivers/staging/iio/dac/ad5446.c | 6 ++++++
> drivers/staging/iio/dac/ad5446.h | 1 +
> 3 files changed, 8 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/staging/iio/dac/Kconfig b/drivers/staging/iio/dac/Kconfig
> index fac8549..daa1079 100644
> --- a/drivers/staging/iio/dac/Kconfig
> +++ b/drivers/staging/iio/dac/Kconfig
> @@ -37,7 +37,7 @@ config AD5446
> help
> Say yes here to build support for Analog Devices AD5444, AD5446,
> AD5512A, AD5542A, AD5543, AD5553, AD5601, AD5611, AD5620, AD5621,
> - AD5640, AD5660 DACs.
> + AD5640, AD5660, AD5662 DACs.
>
> To compile this driver as a module, choose M here: the
> module will be called ad5446.
> diff --git a/drivers/staging/iio/dac/ad5446.c b/drivers/staging/iio/dac/ad5446.c
> index 82ac041..3fcb28b 100644
> --- a/drivers/staging/iio/dac/ad5446.c
> +++ b/drivers/staging/iio/dac/ad5446.c
> @@ -264,6 +264,11 @@ static const struct ad5446_chip_info ad5446_chip_info_tbl[] = {
> .store_sample = ad5660_store_sample,
> .store_pwr_down = ad5660_store_pwr_down,
> },
> + [ID_AD5662] = {
> + .channel = AD5446_CHANNEL(16, 16, 0),
> + .store_sample = ad5660_store_sample,
> + .store_pwr_down = ad5660_store_pwr_down,
> + },
> };
>
> static int ad5446_read_raw(struct iio_dev *indio_dev,
> @@ -433,6 +438,7 @@ static const struct spi_device_id ad5446_id[] = {
> {"ad5640-1250", ID_AD5640_1250},
> {"ad5660-2500", ID_AD5660_2500},
> {"ad5660-1250", ID_AD5660_1250},
> + {"ad5662", ID_AD5662},
> {}
> };
>
> diff --git a/drivers/staging/iio/dac/ad5446.h b/drivers/staging/iio/dac/ad5446.h
> index 4ea3476..f1ca8fe 100644
> --- a/drivers/staging/iio/dac/ad5446.h
> +++ b/drivers/staging/iio/dac/ad5446.h
> @@ -98,6 +98,7 @@ enum ad5446_supported_device_ids {
> ID_AD5640_1250,
> ID_AD5660_2500,
> ID_AD5660_1250,
> + ID_AD5662,
> };
>
> #endif /* IIO_DAC_AD5446_H_ */
next prev parent reply other threads:[~2011-10-31 11:17 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-28 9:05 [PATCH] staging:iio:dac:ad5446: Add support for the AD5662 Lars-Peter Clausen
2011-10-31 11:26 ` Jonathan Cameron [this message]
-- strict thread matches above, loose matches on Subject: below --
2011-11-15 15:34 Lars-Peter Clausen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4EAE85D6.8090206@cam.ac.uk \
--to=jic23@cam.ac.uk \
--cc=device-drivers-devel@blackfin.uclinux.org \
--cc=drivers@analog.com \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=michael.hennerich@analog.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.