From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:39323)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <sw@weilnetz.de>) id 1RKvRN-0000lC-JV
	for qemu-devel@nongnu.org; Mon, 31 Oct 2011 13:14:30 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <sw@weilnetz.de>) id 1RKvRM-0002Eb-Kt
	for qemu-devel@nongnu.org; Mon, 31 Oct 2011 13:14:29 -0400
Received: from v220110690675601.yourvserver.net ([78.47.199.172]:46608)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <sw@weilnetz.de>) id 1RKvRM-0002EW-GP
	for qemu-devel@nongnu.org; Mon, 31 Oct 2011 13:14:28 -0400
Message-ID: <4EAED750.6070801@weilnetz.de>
Date: Mon, 31 Oct 2011 18:13:52 +0100
From: Stefan Weil <sw@weilnetz.de>
MIME-Version: 1.0
References: <1319214405-20388-1-git-send-email-pbonzini@redhat.com>	<1319214405-20388-4-git-send-email-pbonzini@redhat.com>	<CAETRQW=RzJqWSHrqCyH9p50yyZx83NQ3uCe+1Vex_T+G9tsGOA@mail.gmail.com>
	<j8lrtm$p3q$2@dough.gmane.org>
In-Reply-To: <j8lrtm$p3q$2@dough.gmane.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v3 03/13] qemu-timer: move common code to
 qemu_rearm_alarm_timer
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: TeLeMan <geleman@gmail.com>, qemu-devel@nongnu.org

Am 31.10.2011 11:05, schrieb Paolo Bonzini:
> On 10/31/2011 08:23 AM, TeLeMan wrote:
>>> >    static void qemu_rearm_alarm_timer(struct qemu_alarm_timer *t)
>>> >    {
>>> >  -    if (!alarm_has_dynticks(t))
>>> >  +    int64_t nearest_delta_ns;
>>> >  +    assert(alarm_has_dynticks(t));
>> "mmtimer" and "win32" alarms have no rearm. Should we remove these 
>> two alarms?
>
> Yes. I think with iothread they are broken, or almost broken.
>
> Paolo

They can't be more broken: I noticed today that QEMU on W32 aborts
with the default timer (mmtimer) very quickly.

Stefan