From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:47594)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <sw@weilnetz.de>) id 1RKx8A-0006AO-HP
	for qemu-devel@nongnu.org; Mon, 31 Oct 2011 15:02:47 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <sw@weilnetz.de>) id 1RKx89-0000ZW-Kt
	for qemu-devel@nongnu.org; Mon, 31 Oct 2011 15:02:46 -0400
Received: from v220110690675601.yourvserver.net ([78.47.199.172]:34329)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <sw@weilnetz.de>) id 1RKx89-0000ZL-DN
	for qemu-devel@nongnu.org; Mon, 31 Oct 2011 15:02:45 -0400
Message-ID: <4EAEF0A1.2010705@weilnetz.de>
Date: Mon, 31 Oct 2011 20:01:53 +0100
From: Stefan Weil <sw@weilnetz.de>
MIME-Version: 1.0
References: <1319976446-12602-1-git-send-email-sw@weilnetz.de>	<AEFDA1AE-7B6F-4E4D-B3DD-F8B84E4BCCA0@suse.de>	<m3ipn5mzs0.fsf@blackfin.pond.sub.org>
	<4EAED62D.3080602@weilnetz.de>
	<m3bosxko90.fsf@blackfin.pond.sub.org>
In-Reply-To: <m3bosxko90.fsf@blackfin.pond.sub.org>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH] Support running QEMU on Valgrind
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Markus Armbruster <armbru@redhat.com>
Cc: Avi Kivity <avi@redhat.com>, Alexander Graf <agraf@suse.de>, qemu-devel@nongnu.org

Am 31.10.2011 19:30, schrieb Markus Armbruster:
> Copies are evil because we need to pick the one version that's right for
> all our users. Repeatedly.
>
> That's okay (sort of) when there's a tight coupling, and there's really
> only one admissible version.
>
> Or it may be a lesser evil when the thing copied isn't readily available
> (not packaged in common distros).
>
> I can't see either of that for valgrind.h.

Let me add some piece of information for the further discussion.

valgrind.h is an official interface. It is designed to be compatible
across versions.

Initially, I planned to add a valgrind.h copy from my Linux distro.
When I looked at the Valgrind repository, I noticed that the latest
version of valgrind.h had added support for more hosts (ppc, s390)
which I expect will be needed for QEMU soon, so I took this version.

So the decision which copy should be taken is simple: any copy
works as long as it supports your host.

Cheers,
Stefan Weil