From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:47752)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <sw@weilnetz.de>) id 1RKx9T-0006x1-4c
	for qemu-devel@nongnu.org; Mon, 31 Oct 2011 15:04:08 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <sw@weilnetz.de>) id 1RKx9R-0000yK-SL
	for qemu-devel@nongnu.org; Mon, 31 Oct 2011 15:04:07 -0400
Received: from v220110690675601.yourvserver.net ([78.47.199.172]:34648)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <sw@weilnetz.de>) id 1RKx9R-0000yC-MR
	for qemu-devel@nongnu.org; Mon, 31 Oct 2011 15:04:05 -0400
Message-ID: <4EAEF0FB.9030802@weilnetz.de>
Date: Mon, 31 Oct 2011 20:03:23 +0100
From: Stefan Weil <sw@weilnetz.de>
MIME-Version: 1.0
References: <1319976446-12602-1-git-send-email-sw@weilnetz.de>
	<4EAEE55C.7070400@redhat.com>
In-Reply-To: <4EAEE55C.7070400@redhat.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH] Support running QEMU on Valgrind
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Anthony Liguori <anthony@codemonkey.ws>
Cc: qemu-devel@nongnu.org, Avi Kivity <avi@redhat.com>

Am 31.10.2011 19:13, schrieb Anthony Liguori:
> On 10/30/2011 07:07 AM, Stefan Weil wrote:
>> Valgrind is a tool which can automatically detect many kinds of bugs.
>>
>> Running QEMU on Valgrind with x86_64 hosts was not possible because
>> Valgrind aborts when memalign is called with an alignment larger than
>> 1 MiB. QEMU normally uses 2 MiB on Linux x86_64.
>>
>> Now the alignment is reduced to the page size when QEMU is running on
>> Valgrind.
>>
>> valgrind.h is a copy from Valgrind svn trunk r12226 with trailing
>> whitespace stripped but otherwise unmodified, so it still raises lots
>> of errors when checked with scripts/checkpatch.pl.
>>
>> It is included here to avoid a dependency on Valgrind.
>>
>> Signed-off-by: Stefan Weil<sw@weilnetz.de>
>
> How about we just fix valgrind?
>
> Regards,
>
> Anthony Liguori


Do you think that Valgrind will be fixed before tests of QEMU 1.0 start?
I don't, and I think that using Valgrind should be part of these tests!

I'd add the patch now. As soon as Valgrind is fixed, it can be reverted.
Or we add another patch with the Valgrind hack from libvirt.

Regards,
Stefan Weil