From: Marc Kleine-Budde <mkl@pengutronix.de>
To: Reuben Dowle <Reuben.Dowle@navico.com>
Cc: netdev@vger.kernel.org, linux-can@vger.kernel.org
Subject: Re: [PATCH] flexcan: Fix CAN_RAW_RECV_OWN_MSGS and CAN_RAW_LOOPBACK
Date: Mon, 31 Oct 2011 23:49:41 +0100 [thread overview]
Message-ID: <4EAF2605.9090005@pengutronix.de> (raw)
In-Reply-To: <70F6AAAFDC054F41B9994A9BCD3DF64E16FAA211@exch01-aklnz.MARINE.NET.INT>
[-- Attachment #1: Type: text/plain, Size: 868 bytes --]
On 10/31/2011 11:43 PM, Reuben Dowle wrote:
> Currently the flexcan driver uses hardware local echo. This blindly
> echoes all transmitted frames to all receiving sockets, regardless what
> CAN_RAW_RECV_OWN_MSGS and CAN_RAW_LOOPBACK are set to.
>
> This patch now submits transmitted frames to be echoed in the transmit
> complete interrupt, preserving the reference to the sending socket.
> This allows the can protocol to correctly handle the local echo.
>
> Signed-off-by: Reuben Dowle <reuben.dowle@navico.com>
there were some comments inline in my original mail.
Marc
--
Pengutronix e.K. | Marc Kleine-Budde |
Industrial Linux Solutions | Phone: +49-231-2826-924 |
Vertretung West/Dortmund | Fax: +49-5121-206917-5555 |
Amtsgericht Hildesheim, HRA 2686 | http://www.pengutronix.de |
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 262 bytes --]
next prev parent reply other threads:[~2011-10-31 22:49 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-31 22:18 [PATCH] flexcan: Fix CAN_RAW_RECV_OWN_MSGS and CAN_RAW_LOOPBACK Reuben Dowle
2011-10-31 22:18 ` Reuben Dowle
2011-10-31 22:31 ` Marc Kleine-Budde
2011-10-31 22:43 ` Reuben Dowle
2011-10-31 22:43 ` Reuben Dowle
2011-10-31 22:49 ` Marc Kleine-Budde [this message]
2011-11-02 0:25 ` Reuben Dowle
2011-11-02 0:25 ` Reuben Dowle
2011-11-02 8:04 ` Kurt Van Dijck
2011-11-02 19:46 ` Reuben Dowle
2011-11-02 19:46 ` Reuben Dowle
2011-11-02 20:30 ` Oliver Hartkopp
2011-11-02 21:31 ` Reuben Dowle
2011-11-02 21:31 ` Reuben Dowle
2011-11-03 9:47 ` [PATCH 0/2] clean up tx_bytes accounting Marc Kleine-Budde
2011-11-03 9:47 ` [PATCH 1/2] can: dev: let can_get_echo_skb() return dlc of CAN frame Marc Kleine-Budde
2011-11-03 9:47 ` [PATCH 2/2] flexcan: Fix CAN_RAW_RECV_OWN_MSGS and CAN_RAW_LOOPBACK Marc Kleine-Budde
2011-11-03 9:59 ` Marc Kleine-Budde
2011-11-03 10:03 ` Oliver Hartkopp
2011-11-03 10:17 ` Marc Kleine-Budde
2011-11-03 10:03 ` [PATCH 0/2] clean up tx_bytes accounting Kurt Van Dijck
2011-11-03 10:42 ` Marc Kleine-Budde
2011-11-03 14:27 ` Oliver Hartkopp
2011-11-03 14:37 ` Kurt Van Dijck
2011-11-03 15:03 ` Marc Kleine-Budde
2011-11-03 14:54 ` [PATCH] flexcan: Fix CAN_RAW_RECV_OWN_MSGS and CAN_RAW_LOOPBACK Oliver Hartkopp
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4EAF2605.9090005@pengutronix.de \
--to=mkl@pengutronix.de \
--cc=Reuben.Dowle@navico.com \
--cc=linux-can@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.