From: Li Zefan <lizf@cn.fujitsu.com>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: Ilya Dryomov <idryomov@gmail.com>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] tracing: fix event_subsystem ref counting
Date: Tue, 01 Nov 2011 09:12:12 +0800 [thread overview]
Message-ID: <4EAF476C.2060900@cn.fujitsu.com> (raw)
In-Reply-To: <1320077699.4793.5.camel@gandalf.stny.rr.com>
Steven Rostedt wrote:
> On Mon, 2011-10-31 at 11:07 +0200, Ilya Dryomov wrote:
>> Fix a bug introduced by e9dbfae5, which prevents event_subsystem from
>> ever being released.
>>
>> Ref_count was added to keep track of subsystem users, not for counting
>> events. Subsystem is created with ref_count = 1, so there is no need to
>> increment it for every event, we have nr_events for that. Fix this by
>> touching ref_count only when we actually have a new user -
>> subsystem_open().
>
> Good catch, I'll pull this in.
>
I made a different fix last week:
http://marc.info/?l=linux-kernel&m=131978486911595&w=2
but I guess Ilya's version is a bit better.
next prev parent reply other threads:[~2011-11-01 1:10 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-31 9:07 [PATCH] tracing: fix event_subsystem ref counting Ilya Dryomov
2011-10-31 16:14 ` Steven Rostedt
2011-11-01 1:12 ` Li Zefan [this message]
2011-11-01 1:38 ` Steven Rostedt
2011-11-18 23:04 ` [tip:perf/core] " tip-bot for Ilya Dryomov
2011-12-06 6:25 ` tip-bot for Ilya Dryomov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4EAF476C.2060900@cn.fujitsu.com \
--to=lizf@cn.fujitsu.com \
--cc=idryomov@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.