From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:58468) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RL8iV-0002eO-Dv for qemu-devel@nongnu.org; Tue, 01 Nov 2011 03:25:04 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RL8iU-0003kY-DC for qemu-devel@nongnu.org; Tue, 01 Nov 2011 03:25:03 -0400 Received: from v220110690675601.yourvserver.net ([78.47.199.172]:43052) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RL8iU-0003jx-8N for qemu-devel@nongnu.org; Tue, 01 Nov 2011 03:25:02 -0400 Message-ID: <4EAF9E9A.9030407@weilnetz.de> Date: Tue, 01 Nov 2011 08:24:10 +0100 From: Stefan Weil MIME-Version: 1.0 References: <1320111402-1816-1-git-send-email-matthias.bgg@gmail.com> In-Reply-To: <1320111402-1816-1-git-send-email-matthias.bgg@gmail.com> Content-Type: text/plain; charset=ISO-8859-15; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] block.c typo in comment fixed List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Matthias Brugger Cc: qemu-devel@nongnu.org Am 01.11.2011 02:36, schrieb matthias.bgg@googlemail.com: > From: Matthias Brugger > > > Signed-off-by: Matthias Brugger > --- > block.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/block.c b/block.c > index 9bb236c..480aae2 100644 > --- a/block.c > +++ b/block.c > @@ -497,7 +497,7 @@ static int bdrv_open_common(BlockDriverState *bs, const char *filename, > open_flags = flags& ~(BDRV_O_SNAPSHOT | BDRV_O_NO_BACKING); > > /* > - * Snapshots should be writable. > + * Snapshots should be writeable. > */ > if (bs->is_temporary) { > open_flags |= BDRV_O_RDWR; Hi Matthias, both writable and writeable seem to be correct, but http://oxforddictionaries.com/ says that writable is the only correct spelling. Therefore your patch should not be used. Cheers, Stefan