All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stephen Clark <sclark46@earthlink.net>
To: "Ted Ts'o" <tytso@mit.edu>,
	Vincent Pelletier <plr.vincent@gmail.com>,
	linux-kernel@vger.kernel.org
Subject: Re: ext4 bug ? "Intel 320 SSD write performance – contd."
Date: Tue, 01 Nov 2011 09:34:04 -0400	[thread overview]
Message-ID: <4EAFF54C.7010406@earthlink.net> (raw)
In-Reply-To: <20111031210951.GK16825@thunk.org>

On 10/31/2011 05:09 PM, Ted Ts'o wrote:
> On Mon, Oct 31, 2011 at 09:38:37PM +0100, Vincent Pelletier wrote:
>    
>> Reading this blog post[1], I thought the "2nd iteration" results could be
>> considered a bug in mkfs.ext4 (and possibly any mkfs implementation):
>> shouldn't mkfs run [FI]TRIM on its target before creating filesystem
>> structure ?
>>      
> It's not enabled by default, because there are crappy SSD's out there
> where use of the TRIM command will turn them into bricks.  (No, it's
> not the Intel X-25 drives that I'm worried about.)
>
> So I (and the distributions) don't want to make it the default, since
> if you buy crap drives and then mke2fs turns them into bricks, who are
> you likely to blame?  The crap SSD manufacturer?  Yourself for trying
> to buy SSD's on the cheap?  Or the program that issued the TRIM
> command?
>
> You can enable the trim behaviour by default by adding to your
> /etc/mke2fs.conf file:
>
> [defaults]
> 	discard = true
>
> But then it's on your head if anything bad happens.  :-/
>
>          	      	      	      - Ted
>
>    
<snip>

What about using discard in fstab like:
LABEL=/ /                      ext4    
defaults,discard,noatime,nodiratime        1 1

Thanks,
Steve

-- 

"They that give up essential liberty to obtain temporary safety,
deserve neither liberty nor safety."  (Ben Franklin)

"The course of history shows that as a government grows, liberty
decreases."  (Thomas Jefferson)




  parent reply	other threads:[~2011-11-01 13:34 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-10-31 20:38 ext4 bug ? "Intel 320 SSD write performance – contd." Vincent Pelletier
2011-10-31 21:09 ` Ted Ts'o
2011-10-31 21:47   ` Vincent Pelletier
2011-11-01 13:34   ` Stephen Clark [this message]
2011-11-01 13:41     ` Theodore Tso
2011-11-01 14:00       ` Stephen Clark
2012-01-15 18:37   ` ext4 bug ? "Intel 320 SSD write performance ??? contd." Pavel Machek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4EAFF54C.7010406@earthlink.net \
    --to=sclark46@earthlink.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=plr.vincent@gmail.com \
    --cc=tytso@mit.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.