From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:37008) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RLJli-0000Rr-Mt for qemu-devel@nongnu.org; Tue, 01 Nov 2011 15:13:07 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RLJlh-000604-J7 for qemu-devel@nongnu.org; Tue, 01 Nov 2011 15:13:06 -0400 Received: from fmmailgate01.web.de ([217.72.192.221]:60747) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RLJlh-0005zh-7z for qemu-devel@nongnu.org; Tue, 01 Nov 2011 15:13:05 -0400 Received: from moweb002.kundenserver.de (moweb002.kundenserver.de [172.19.20.108]) by fmmailgate01.web.de (Postfix) with ESMTP id C30D01A2D1BB1 for ; Tue, 1 Nov 2011 20:13:03 +0100 (CET) Message-ID: <4EB0446E.8080601@web.de> Date: Tue, 01 Nov 2011 20:11:42 +0100 From: =?ISO-8859-1?Q?Andreas_F=E4rber?= MIME-Version: 1.0 References: <4EB0202E.50701@web.de> <1320170376-21605-1-git-send-email-andreas.faerber@web.de> <4EB034F5.7060408@web.de> <9767C2D2-8BFD-4A17-AE4D-9C0B9A612002@sunshineco.com> In-Reply-To: <9767C2D2-8BFD-4A17-AE4D-9C0B9A612002@sunshineco.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH v3 2/4] softfloat: Avoid uint16 type conflict on Darwin List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eric Sunshine Cc: Peter Maydell , Juan Pineda , qemu-devel@nongnu.org Am 01.11.2011 19:55, schrieb Eric Sunshine: > On Nov 1, 2011, at 2:05 PM, Andreas F=E4rber wrote: >> Am 01.11.2011 19:01, schrieb Peter Maydell: >>> On 1 November 2011 17:59, Andreas F=E4rber w= rote: >>>> Apple's FSEvents.h has #include , which wants >>>> /usr/include/Block.h but due to case-insensitive file system and >>>> include path jungle gets QEMU's ./block.h, which in turn includes >>>> softfloat.h indirectly. >>> >>> Incidentally, surely you need to fix this anyway (ie fix the >>> include path issue somehow)? >> >> Yes, that's why I'm explicitly documenting it. I have no clue how to f= ix >> it though. Experts' opinion welcome! >=20 >=20 > It probably is not a good idea to emphasize the particular #include > stack issued by this one build environment (presumably XCode on Lion?) > so loudly in the commit message. The type redefinition error will > manifest regardless of #include ordering and regardless of whether or > not ./block.h is picked up accidentally instead of . For > instance, on Leopard with XCode 3.1.4, the #include stack emitted with > the error message is entirely different even though the underlying issu= e > is the same: >=20 > OBJC ui/cocoa.o > In file included from ./bswap.h:8, > from ./qemu-common.h:107, > from ui/cocoa.m:29: > /Users/sunshine/Desktop/qemu/fpu/softfloat.h:60: error: conflicting > types for 'uint16' > /System/Library/Frameworks/Security.framework/Headers/cssmconfig.h:68: > error: previous declaration of 'uint16' was here > make: *** [ui/cocoa.o] Error 1 >=20 > In fact, on Leopard, FSEvents.h does not #include , so focusin= g > on it in the log message is misleading. My point is, that's the reason it needs to be fixed *this* way and not in cocoa.m like you'd expect. If it doesn't show up in git-blame, people will not understand and "clean up". It's always just an example since it includes user-specific paths - here Snow Leopard. Rewording. AF