From: Saul Wold <saul.wold@intel.com>
To: Patches and discussions about the oe-core layer
<openembedded-core@lists.openembedded.org>
Cc: Martin Jansa <martin.jansa@gmail.com>
Subject: Re: [PATCH 2/4] xserver-nodm-init: Add xuser (hardcoded)
Date: Tue, 01 Nov 2011 14:35:48 -0700 [thread overview]
Message-ID: <4EB06634.6090204@intel.com> (raw)
In-Reply-To: <20111101213059.GB9949@jama.jama.net>
On 11/01/2011 02:30 PM, Martin Jansa wrote:
> On Tue, Nov 01, 2011 at 02:27:17PM -0700, Saul Wold wrote:
>> Signed-off-by: Saul Wold<sgw@linux.intel.com>
>> ---
>> .../x11-common/xserver-nodm-init.bb | 30 +++++++------------
>> 1 files changed, 11 insertions(+), 19 deletions(-)
>>
>> diff --git a/meta/recipes-graphics/x11-common/xserver-nodm-init.bb b/meta/recipes-graphics/x11-common/xserver-nodm-init.bb
>> index ea4222d..1183f0e 100644
>> --- a/meta/recipes-graphics/x11-common/xserver-nodm-init.bb
>> +++ b/meta/recipes-graphics/x11-common/xserver-nodm-init.bb
>> @@ -2,7 +2,7 @@ DESCRIPTION = "Simple Xserver Init Script (no dm)"
>> LICENSE = "GPLv2"
>> LIC_FILES_CHKSUM = "file://COPYING;md5=751419260aa954499f7abaabaa882bbe"
>> SECTION = "x11"
>> -PR = "r26"
>> +PR = "r28"
>> RDEPENDS_${PN} = "sudo"
>>
>> SRC_URI = "file://xserver-nodm \
>> @@ -19,27 +19,19 @@ do_install() {
>> install xserver-nodm ${D}/etc/init.d
>> if [ "${ROOTLESS_X}" = "1" ] ; then
>> install -d ${D}/etc/X11
>> - install Xusername ${D}/etc/X11
>> + install Xusername ${D}/etc/X11
>> fi
>> }
>>
>> -pkg_postinst_${PN} () {
>> - if [ "x$D" != "x" ] ; then
>> - exit 1
>> - fi
>> -
>> - if [ -f /etc/X11/Xusername ]; then
>> - # create the rootless X user, and add user to group tty, video, audio
>> - username=`cat /etc/X11/Xusername`
>> - adduser --disabled-password $username
>> - # FIXME: use addgroup if busybox addgroup is ready
>> - sed -i -e "s/^video:.*/&${username}/g" /etc/group
>> - sed -i -e "s/^tty:.*/&${username}/g" /etc/group
>> - sed -i -e "s/^audio:.*/&${username}/g" /etc/group
>> - fi
>> -}
>> -
>> -inherit update-rc.d
>> +inherit update-rc.d useradd
>>
>> INITSCRIPT_NAME = "xserver-nodm"
>> INITSCRIPT_PARAMS = "start 9 5 2 . stop 20 0 1 6 ."
>> +
>> +# Use fixed Xusername of xuser for now, this will need to be
>> +# fixed if the Xusername changes from xuser
>> +USERADD_PACKAGES = "${PN}"
>> +USERADD_PARAM_${PN} = "--system --no-create-home \
>> + --shell /bin/false --groups video,tty,audioi \
>
> audioi?
>
> I guess you're also using vim :)
i
good catch (fixed in the branch)
:w
:q
:-)
Sau!
>
> Cheers,
>
>> + --user-group xuser"
>> +
>> --
>> 1.7.6.4
>>
>>
>> _______________________________________________
>> Openembedded-core mailing list
>> Openembedded-core@lists.openembedded.org
>> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
>
>
>
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
next prev parent reply other threads:[~2011-11-01 21:42 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-01 21:27 [PATCH 0/4] convert these recipes to adduser bbclass Saul Wold
2011-11-01 21:27 ` [PATCH 1/4] avahi: use useradd to create user Saul Wold
2011-11-01 21:27 ` [PATCH 2/4] xserver-nodm-init: Add xuser (hardcoded) Saul Wold
2011-11-01 21:30 ` Martin Jansa
2011-11-01 21:35 ` Saul Wold [this message]
2011-11-01 21:27 ` [PATCH 3/4] connman: create xuser Saul Wold
2011-11-01 21:27 ` [PATCH 4/4] dbus: fix up ADDUSER_PARAMS Saul Wold
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4EB06634.6090204@intel.com \
--to=saul.wold@intel.com \
--cc=martin.jansa@gmail.com \
--cc=openembedded-core@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.