From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:58573)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <anthony@codemonkey.ws>) id 1RLMde-0006Oy-Mf
	for qemu-devel@nongnu.org; Tue, 01 Nov 2011 18:16:59 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <anthony@codemonkey.ws>) id 1RLMdd-0007hG-NL
	for qemu-devel@nongnu.org; Tue, 01 Nov 2011 18:16:58 -0400
Message-ID: <4EB06FD3.1040708@codemonkey.ws>
Date: Tue, 01 Nov 2011 17:16:51 -0500
From: Anthony Liguori <anthony@codemonkey.ws>
MIME-Version: 1.0
References: <1320006193-15219-1-git-send-email-agraf@suse.de>	<CAAu8pHtKRi+fu0KL4CtYrJ5uP4OrqPZYjirKTpT90cs-Dh4eCw@mail.gmail.com>	<4EB067A2.70203@codemonkey.ws>
	<9C67C675-3339-4467-A52B-73163DF07553@suse.de>
In-Reply-To: <9C67C675-3339-4467-A52B-73163DF07553@suse.de>
Content-Type: text/plain; charset=GB2312
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PULL 00/22] ppc patch queue 2011-10-30
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Alexander Graf <agraf@suse.de>
Cc: Blue Swirl <blauwirbel@gmail.com>, "qemu-ppc@nongnu.org" <qemu-ppc@nongnu.org>, "qemu-devel@nongnu.org" <qemu-devel@nongnu.org>

On 11/01/2011 05:14 PM, Alexander Graf wrote:
>> And specifically:
>>
>>         QLIST_FOREACH(qdev,&phb->host_state.bus->qbus.children, sibling) {
>>             PCIDevice *dev = (PCIDevice *)qdev;
>>             if (dev->devfn == devfn) {
>>                 return dev;
>>             }
>>         }
>>
>> QBus::children is a QTAILQ, not a QLIST.
>>
>> Was this code tested at all?
> 
> Uh, yeah. Compile and execution tested O_o.

Do you not have libfdt installed?

Regards,

Anthony Liguori

> 
> Alex
> 
>