From: Denis Kenzior <denkenz@gmail.com>
To: ofono@ofono.org
Subject: Re: [PATCH v5] hfp_hf: BT address exposed through Serial property
Date: Tue, 01 Nov 2011 18:52:51 -0500 [thread overview]
Message-ID: <4EB08653.5030400@gmail.com> (raw)
In-Reply-To: <1320241555-16727-1-git-send-email-mikel.astiz@bmw-carit.de>
[-- Attachment #1: Type: text/plain, Size: 561 bytes --]
Hi Mikel,
On 11/02/2011 08:45 AM, Mikel Astiz wrote:
> The devinfo atom is created in pre_sim (instead of probe).
> ---
> plugins/hfp_hf.c | 13 +++++++++++++
> 1 files changed, 13 insertions(+), 0 deletions(-)
>
Patch has been applied, I did fix up a minor style violation in a follow
on commit:
> @@ -239,6 +246,10 @@ static int hfp_hf_probe(const char *device, const char *dev_addr,
> return 0;
>
> free:
> + if (data != NULL) {
> + g_free(data->handsfree_path);
> + }
> +
The brackets are not needed...
Regards,
-Denis
prev parent reply other threads:[~2011-11-01 23:52 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-02 13:45 [PATCH v5] hfp_hf: BT address exposed through Serial property Mikel Astiz
2011-11-01 23:52 ` Denis Kenzior [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4EB08653.5030400@gmail.com \
--to=denkenz@gmail.com \
--cc=ofono@ofono.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.