From mboxrd@z Thu Jan  1 00:00:00 1970
From: Tomoya MORINAGA <tomoya-linux@dsn.lapis-semi.com>
Subject: Re: [PATCH 2/2] pch_uart: Delete modem status interrupt enable code
Date: Wed, 02 Nov 2011 14:52:54 +0900
Message-ID: <4EB0DAB6.7000106@dsn.lapis-semi.com>
References: <1319697919-5623-1-git-send-email-tomoya-linux@dsn.lapis-semi.com>	<1319697919-5623-2-git-send-email-tomoya-linux@dsn.lapis-semi.com> <20111101125757.4ef7f883@bob.linux.org.uk>
Mime-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Return-path: <linux-kernel-owner@vger.kernel.org>
In-Reply-To: <20111101125757.4ef7f883@bob.linux.org.uk>
Sender: linux-kernel-owner@vger.kernel.org
To: Alan Cox <alan@linux.intel.com>
Cc: gregkh@suse.de, linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org, qi.wang@intel.com, yong.y.wang@intel.com, joel.clark@intel.com, kok.howg.ewe@intel.com
List-Id: linux-serial@vger.kernel.org

(2011/11/01 21:57), Alan Cox wrote:
>> (pch_uart device has auto hardware flow control function. So,
>> pch_uart driver doesn't have to control modem status interrupt.)
>
> This is true for flow control bits but not for incoming carrier detect ?

Called ".get_mctrl" function, other software can know incoming carrier 
detection.
Or you mean a uart driver must detect incoming carrier with interrupt ?

>> This patch deletes the code.
>
>> +	dev_info(priv->port.dev,
>> +		"PCH UART : Modem status interrupt is not
>> supported.\n"); }
>
> dev_info seems wrong here. Does the user need to know this ?
OK, a user doesn't have to know the information.
I will delete the dev_info.

Thanks,
-- 
tomoya
ROHM Co., Ltd.