All of lore.kernel.org
 help / color / mirror / Atom feed
From: Paolo Bonzini <pbonzini@redhat.com>
To: qemu-devel <qemu-devel@nongnu.org>, Jun Koi <junkoi2004@gmail.com>
Subject: Re: [Qemu-devel] [patch] remove unused function arg in qemu_iohandler_poll() and qemu_iohandler_fill()
Date: Wed, 02 Nov 2011 08:40:01 +0100	[thread overview]
Message-ID: <4EB0F3D1.9050903@redhat.com> (raw)
In-Reply-To: <CA+g7VZ2g0CdpYWY+wUuOk3Oi-C_penszMaJvF1VJCt0+tzRn0Q@mail.gmail.com>

On 11/01/2011 06:11 AM, Jun Koi wrote:
> This patch removes unused function argument xfds from
> qemu_iohandler_poll() and qemu_iohandler_fill()

I don't think the patch us particularly useful; the arguments are 
designed to match select.  The fact that iohandlers do not support xfds 
(unlike e.g. glib and slirp poll/fill) is not important to the _client_ 
of this code.

Thanks,

Paolo

  parent reply	other threads:[~2011-11-02  7:40 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-11-01  5:11 [Qemu-devel] [patch] remove unused function arg in qemu_iohandler_poll() and qemu_iohandler_fill() Jun Koi
2011-11-01 15:05 ` Anthony Liguori
2011-11-02  1:46   ` Jun Koi
2011-11-02 10:38     ` Stefan Hajnoczi
2011-11-02  7:40 ` Paolo Bonzini [this message]
2011-11-02  8:05   ` Jun Koi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4EB0F3D1.9050903@redhat.com \
    --to=pbonzini@redhat.com \
    --cc=junkoi2004@gmail.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.