From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christoph Egger Subject: Re: [PATCH] pm : provide CC7/PC2 residency Date: Wed, 2 Nov 2011 10:56:38 +0100 Message-ID: <4EB113D6.4010807@amd.com> References: <749B9D3DBF0F054390025D9EAFF47F2212D2A848E5@shsmsx501.ccr.corp.intel.com> <4EB11212020000780005E5F5@nat28.tlf.novell.com> <749B9D3DBF0F054390025D9EAFF47F2212D5AEEE4A@shsmsx501.ccr.corp.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="ISO-8859-1"; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <749B9D3DBF0F054390025D9EAFF47F2212D5AEEE4A@shsmsx501.ccr.corp.intel.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: "Zhang, Yang Z" Cc: "xen-devel@lists.xensource.com" , Keir Fraser , Jan Beulich List-Id: xen-devel@lists.xenproject.org On 11/02/11 10:48, Zhang, Yang Z wrote: >> From: Jan Beulich [mailto:JBeulich@suse.com] >>>>> On 25.10.11 at 15:34, "Zhang, Yang Z" wrote: >>> --- a/xen/include/public/sysctl.h Mon Oct 24 18:01:07 2011 +0100 >>> +++ b/xen/include/public/sysctl.h Fri Oct 28 21:33:07 2011 +0800 >>> @@ -225,11 +225,13 @@ >>> uint64_aligned_t idle_time; /* idle time from boot */ >>> XEN_GUEST_HANDLE_64(uint64) triggers; /* Cx trigger counts */ >>> XEN_GUEST_HANDLE_64(uint64) residencies; /* Cx residencies */ >>> + uint64_aligned_t pc2; >>> uint64_aligned_t pc3; >>> uint64_aligned_t pc6; >>> uint64_aligned_t pc7; >>> uint64_aligned_t cc3; >>> uint64_aligned_t cc6; >>> + uint64_aligned_t cc7; >>> }; >>> >>> struct xen_sysctl_get_pmstat { >> >> Structure layout changes like this should be accompanied by a bump of >> XEN_SYSCTL_INTERFACE_VERSION - is there any reason not to do so in this case? > Can you explain what's the problem? Are you mean new xen with old tools will have problem or anything else? The problem is API/ABI backward-compatibility. Christoph -- ---to satisfy European Law for business letters: Advanced Micro Devices GmbH Einsteinring 24, 85689 Dornach b. Muenchen Geschaeftsfuehrer: Alberto Bozzo, Andrew Bowd Sitz: Dornach, Gemeinde Aschheim, Landkreis Muenchen Registergericht Muenchen, HRB Nr. 43632