From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christoph Egger Subject: Re: [PATCH] libxl: allow to enable/disable cpuid bits Date: Wed, 2 Nov 2011 11:44:32 +0100 Message-ID: <4EB11F10.2030605@amd.com> References: <4EAFD200.4010207@amd.com> <20144.17265.621187.887785@mariner.uk.xensource.com> <4EB10C00.10601@amd.com> <20111102102039.GA35143@ocelot.phlegethon.org> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="------------070409060508010001020908" Return-path: In-Reply-To: <20111102102039.GA35143@ocelot.phlegethon.org> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Tim Deegan Cc: Keir Fraser , "xen-devel@lists.xensource.com" , Ian Jackson List-Id: xen-devel@lists.xenproject.org --------------070409060508010001020908 Content-Type: text/plain; charset="ISO-8859-1"; format=flowed Content-Transfer-Encoding: 7bit On 11/02/11 11:20, Tim Deegan wrote: > At 10:23 +0100 on 02 Nov (1320229392), Christoph Egger wrote: >> On 11/01/11 20:07, Ian Jackson wrote: >>> Christoph Egger writes ("[Xen-devel] [PATCH] libxl: allow to >>> enable/disable cpuid bits"): >>>> >>>> Allow to enable/disable SVM specific cpuid bits >>>> in the guest config file via cpuid config option. >>>> Also allow to enable/disable the hypervisor cpuid bit >>>> in the guest config file. We need to disable the >>>> hypervisor cpuid bit to get Hyper-V going. >>> >>> The change itself looks plausible to me. However I don't know much >>> about cpuid; can you get an ack from a hypervisor maintainer or an >>> suitable expert ? >> >> Keir? Tim? > > I think the hypervisor bit should be given a better name than 'raz' -- > although it is read-as-zero on real hardware that doesn't distinguish it > from other raz bits, or describe what it does. > > 'hypervisor' maybe, to match 'X86_FEATURE_HYPERVISOR' elsewhere in the > Xen code? > > With that change, Acked-by: Tim Deegan New version with that change attached. Signed-off-by: Christoph Egger -- ---to satisfy European Law for business letters: Advanced Micro Devices GmbH Einsteinring 24, 85689 Dornach b. Muenchen Geschaeftsfuehrer: Alberto Bozzo, Andrew Bowd Sitz: Dornach, Gemeinde Aschheim, Landkreis Muenchen Registergericht Muenchen, HRB Nr. 43632 --------------070409060508010001020908 Content-Type: text/plain; name="xen_tools_libxl_cpuid.diff" Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename="xen_tools_libxl_cpuid.diff" Content-Description: xen_tools_libxl_cpuid.diff diff -r 0d092359d86f tools/libxl/libxl_cpuid.c --- a/tools/libxl/libxl_cpuid.c Wed Oct 26 10:32:36 2011 +0200 +++ b/tools/libxl/libxl_cpuid.c Wed Nov 02 11:41:51 2011 +0100 @@ -92,6 +92,7 @@ int libxl_cpuid_parse_config(libxl_cpuid {"proccount", 0x00000001, NA, CPUID_REG_EBX, 16, 8}, {"clflush", 0x00000001, NA, CPUID_REG_EBX, 8, 8}, {"brandid", 0x00000001, NA, CPUID_REG_EBX, 0, 8}, + {"hypervisor", 0x00000001, NA, CPUID_REG_ECX, 31, 1}, {"f16c", 0x00000001, NA, CPUID_REG_ECX, 29, 1}, {"avx", 0x00000001, NA, CPUID_REG_ECX, 28, 1}, {"osxsave", 0x00000001, NA, CPUID_REG_ECX, 27, 1}, @@ -178,6 +179,13 @@ int libxl_cpuid_parse_config(libxl_cpuid {"procpkg", 0x00000004, 0, CPUID_REG_EAX, 26, 6}, {"apicidsize", 0x80000008, NA, CPUID_REG_ECX, 12, 4}, {"nc", 0x80000008, NA, CPUID_REG_ECX, 0, 8}, + {"svm_npt", 0x8000000a, NA, CPUID_REG_EDX, 0, 1}, + {"svm_lbrv", 0x8000000a, NA, CPUID_REG_EDX, 1, 1}, + {"svm_nrips", 0x8000000a, NA, CPUID_REG_EDX, 3, 1}, + {"svm_tscrate", 0x8000000a, NA, CPUID_REG_EDX, 4, 1}, + {"svm_vmcbclean",0x8000000a, NA, CPUID_REG_EDX, 5, 1}, + {"svm_decode", 0x8000000a, NA, CPUID_REG_EDX, 7, 1}, + {"svm_pausefilt",0x8000000a, NA, CPUID_REG_EDX, 10, 1}, {NULL, 0, CPUID_REG_INV, 0, 0} }; --------------070409060508010001020908 Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel --------------070409060508010001020908--