From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:42118)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <sw@weilnetz.de>) id 1RLavg-0001B9-M0
	for qemu-devel@nongnu.org; Wed, 02 Nov 2011 09:32:33 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <sw@weilnetz.de>) id 1RLavf-00033U-JI
	for qemu-devel@nongnu.org; Wed, 02 Nov 2011 09:32:32 -0400
Received: from v220110690675601.yourvserver.net ([78.47.199.172]:45552)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <sw@weilnetz.de>) id 1RLavf-000321-EF
	for qemu-devel@nongnu.org; Wed, 02 Nov 2011 09:32:31 -0400
Message-ID: <4EB1462F.3070005@weilnetz.de>
Date: Wed, 02 Nov 2011 14:31:27 +0100
From: Stefan Weil <sw@weilnetz.de>
MIME-Version: 1.0
References: <1319214405-20388-1-git-send-email-pbonzini@redhat.com>	<1319214405-20388-4-git-send-email-pbonzini@redhat.com>	<CAETRQW=RzJqWSHrqCyH9p50yyZx83NQ3uCe+1Vex_T+G9tsGOA@mail.gmail.com>	<j8lrtm$p3q$2@dough.gmane.org>
	<4EAED750.6070801@weilnetz.de> <4EB13DA0.5050100@redhat.com>
In-Reply-To: <4EB13DA0.5050100@redhat.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v3 03/13] qemu-timer: move common code to
 qemu_rearm_alarm_timer
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: qemu-devel <qemu-devel@nongnu.org>

Am 02.11.2011 13:54, schrieb Paolo Bonzini:
> On 10/31/2011 06:13 PM, Stefan Weil wrote:
>>>
>>
>> They can't be more broken: I noticed today that QEMU on W32 aborts
>> with the default timer (mmtimer) very quickly.
>
> Is there any reason why mmtimer2 is not the default (or indeed why 
> mmtimer and win32 exist)?
>
> Paolo
>

Commit 68c23e5520e8286d79d96ab47c0ea722ceb75041 removed
the multimedia timers, so only timer "win32" was left:

use win32 timer queues

     Multimedia timers are only useful for compatibility with Windows NT 4.0
     and earlier.  Plus, the implementation in Wine is extremely 
heavyweight.

Commit 2f9cba0c148af32fad6813480f5c92efe17c2d49 re-added
mmtimer2 because it had existed before (it was called "dynticks" and
the default for w32) and was needed for Linux. It also added mmtimer,
a multimedia timer without rearm.

qemu-timer: Fix timers for w32

     Commit 68c23e5520e8286d79d96ab47c0ea722ceb75041 removed the
     multimedia timer, but this timer is needed for certain
     Linux kernels. Otherwise Linux boot stops with this error:

         MP-BIOS bug: 8254 timer not connected to IO-APIC

     So the multimedia timer is added again here.

Now timers without rearm no longer work (abort in assertion).

I think mmtimer2 would be sufficient. For QEMU 1.0, it should be
the default, because otherwise w32 users won't be able to use it.

The arguments from the first patch are still valid, I suppose,
so removing the other timers (mmtimer and win32) should be
delayed until you, I (not before end of next week) or someone
else has done more tests on w32 and wine.

Regards
Stefan