All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ben Greear <greearb@candelatech.com>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: linux-wireless@vger.kernel.org
Subject: Re: [wireless-next PATCH v2 1/4] mac80211: Support forcing station to disable 11n.
Date: Wed, 02 Nov 2011 09:40:14 -0700	[thread overview]
Message-ID: <4EB1726E.5010503@candelatech.com> (raw)
In-Reply-To: <1320220666.3950.6.camel@jlt3.sipsolutions.net>

On 11/02/2011 12:57 AM, Johannes Berg wrote:
> On Fri, 2011-10-28 at 15:21 -0700, greearb@candelatech.com wrote:
>> From: Ben Greear<greearb@candelatech.com>
>>
>> This allows a user to configure a wifi station interface
>> to disable 802.11n, even if the AP and NIC supports it.
>
> You really should've waited for the review on v1 to finish -- this v2 is
> worthless. That makes John think that you addressed all review feedback,
> when really we didn't even finish discussing some points; eventually
> that'll just force me to have my own tree so John isn't confused all the
> time.

I explicitly noted in the comments for several of the patches
that I did not address all of your comments.  I re-posted because
I thought I could at least fix some of your concerns and hopefully
get the patches closer to right and make further reviews easier.

Thanks,
Ben

>
> johannes


-- 
Ben Greear <greearb@candelatech.com>
Candela Technologies Inc  http://www.candelatech.com


  reply	other threads:[~2011-11-02 16:40 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-10-28 22:21 [wireless-next PATCH v2 1/4] mac80211: Support forcing station to disable 11n greearb
2011-10-28 22:21 ` [wireless-next PATCH v2 2/4] wifi: Support disabling ht40 greearb
2011-10-28 22:21 ` [wireless-next PATCH v2 3/4] wifi: Allow overriding some HT information greearb
2011-10-28 22:21 ` [wireless-next PATCH v2 4/4] ath9k: Support modifying AMSDU and AMPDU settings greearb
2011-11-02  7:57 ` [wireless-next PATCH v2 1/4] mac80211: Support forcing station to disable 11n Johannes Berg
2011-11-02 16:40   ` Ben Greear [this message]
2011-11-02 17:51     ` Johannes Berg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4EB1726E.5010503@candelatech.com \
    --to=greearb@candelatech.com \
    --cc=johannes@sipsolutions.net \
    --cc=linux-wireless@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.