diff for duplicates of <4EB1784C.4090903@oracle.com> diff --git a/a/1.txt b/N1/1.txt index 47ca777..a779255 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -44,7 +44,7 @@ On 11/02/2011 12:39 AM, Dan Carpenter wrote: >> However, this is not the correct solution. The goal of the >> original code, which used to use list_for_each(), was to leave lock >> non-NULL if the cookie was found. Your version merely exits the loop on ->> the first non-matching entry, always leaving lock=NULL if there is a +>> the first non-matching entry, always leaving lock==NULL if there is a >> non-matching entry. >> One possible solution is to return the original code: >> @@ -69,7 +69,7 @@ On 11/02/2011 12:39 AM, Dan Carpenter wrote: >> + list_for_each(iter, tmpq) { >> + lock = list_entry(iter, struct dlm_lock, list); >> + ->> + if (lock->ml.cookie = ml->cookie) +>> + if (lock->ml.cookie == ml->cookie) >> break; >> + lock = NULL; >> } @@ -88,7 +88,7 @@ On 11/02/2011 12:39 AM, Dan Carpenter wrote: >> - if (lock->ml.cookie != ml->cookie) >> - lock = NULL; >> - else ->> + if (lock->ml.cookie = ml->cookie) +>> + if (lock->ml.cookie == ml->cookie) >> break; >> } >> - if (lock) @@ -113,9 +113,9 @@ On 11/02/2011 12:39 AM, Dan Carpenter wrote: >> Joel Becker >> Consulting Software Developer >> Oracle ->> E-mail: joel.becker@oracle.com +>> E-mail: joel.becker at oracle.com >> Phone: (650) 506-8127 >> -- >> To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in ->> the body of a message to majordomo@vger.kernel.org +>> the body of a message to majordomo at vger.kernel.org >> More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/a/content_digest b/N1/content_digest index 0239c4c..fedc994 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -2,8 +2,8 @@ "ref\020100812000355.GA7195@mail.oracle.com\0" "ref\020111102073928.GA23750@mwanda\0" "From\0Sunil Mushran <sunil.mushran@oracle.com>\0" - "Subject\0Re: [PATCH 1/2] fs/ocfs2/dlm: Eliminate update of list_for_each_entry\0" - "Date\0Wed, 02 Nov 2011 17:05:16 +0000\0" + "Subject\0[Ocfs2-devel] [PATCH 1/2] fs/ocfs2/dlm: Eliminate update of list_for_each_entry loop cursor\0" + "Date\0Wed, 02 Nov 2011 10:05:16 -0700\0" "To\0Dan Carpenter <dan.carpenter@oracle.com>\0" "Cc\0Julia Lawall <julia@diku.dk>" Mark Fasheh <mfasheh@suse.com> @@ -58,7 +58,7 @@ ">> \tHowever, this is not the correct solution. The goal of the\n" ">> original code, which used to use list_for_each(), was to leave lock\n" ">> non-NULL if the cookie was found. Your version merely exits the loop on\n" - ">> the first non-matching entry, always leaving lock=NULL if there is a\n" + ">> the first non-matching entry, always leaving lock==NULL if there is a\n" ">> non-matching entry.\n" ">> \tOne possible solution is to return the original code:\n" ">>\n" @@ -83,7 +83,7 @@ ">> +\t\t\t\tlist_for_each(iter, tmpq) {\n" ">> +\t\t\t\t\tlock = list_entry(iter, struct dlm_lock, list);\n" ">> +\n" - ">> +\t\t\t\t\tif (lock->ml.cookie = ml->cookie)\n" + ">> +\t\t\t\t\tif (lock->ml.cookie == ml->cookie)\n" ">> \t\t\t\t\t\tbreak;\n" ">> +\t\t\t\t\tlock = NULL;\n" ">> \t\t\t\t}\n" @@ -102,7 +102,7 @@ ">> -\t\t\t\t\tif (lock->ml.cookie != ml->cookie)\n" ">> -\t\t\t\t\t\tlock = NULL;\n" ">> -\t\t\t\t\telse\n" - ">> +\t\t\t\t\tif (lock->ml.cookie = ml->cookie)\n" + ">> +\t\t\t\t\tif (lock->ml.cookie == ml->cookie)\n" ">> \t\t\t\t\t\tbreak;\n" ">> \t\t\t\t}\n" ">> -\t\t\t\tif (lock)\n" @@ -127,11 +127,11 @@ ">> Joel Becker\n" ">> Consulting Software Developer\n" ">> Oracle\n" - ">> E-mail: joel.becker@oracle.com\n" + ">> E-mail: joel.becker at oracle.com\n" ">> Phone: (650) 506-8127\n" ">> --\n" ">> To unsubscribe from this list: send the line \"unsubscribe kernel-janitors\" in\n" - ">> the body of a message to majordomo@vger.kernel.org\n" + ">> the body of a message to majordomo at vger.kernel.org\n" >> More majordomo info at http://vger.kernel.org/majordomo-info.html -2011f8a254e39911e277fbc63bd5c879eb792978955d5b80064a6bb29125bc83 +2440b870685ee4ad9b09bf299135116767599b224e4e48ffe2807703ea981e3e
diff --git a/a/1.txt b/N2/1.txt index 47ca777..88cd45d 100644 --- a/a/1.txt +++ b/N2/1.txt @@ -44,7 +44,7 @@ On 11/02/2011 12:39 AM, Dan Carpenter wrote: >> However, this is not the correct solution. The goal of the >> original code, which used to use list_for_each(), was to leave lock >> non-NULL if the cookie was found. Your version merely exits the loop on ->> the first non-matching entry, always leaving lock=NULL if there is a +>> the first non-matching entry, always leaving lock==NULL if there is a >> non-matching entry. >> One possible solution is to return the original code: >> @@ -69,7 +69,7 @@ On 11/02/2011 12:39 AM, Dan Carpenter wrote: >> + list_for_each(iter, tmpq) { >> + lock = list_entry(iter, struct dlm_lock, list); >> + ->> + if (lock->ml.cookie = ml->cookie) +>> + if (lock->ml.cookie == ml->cookie) >> break; >> + lock = NULL; >> } @@ -88,7 +88,7 @@ On 11/02/2011 12:39 AM, Dan Carpenter wrote: >> - if (lock->ml.cookie != ml->cookie) >> - lock = NULL; >> - else ->> + if (lock->ml.cookie = ml->cookie) +>> + if (lock->ml.cookie == ml->cookie) >> break; >> } >> - if (lock) diff --git a/a/content_digest b/N2/content_digest index 0239c4c..170f3d5 100644 --- a/a/content_digest +++ b/N2/content_digest @@ -2,8 +2,8 @@ "ref\020100812000355.GA7195@mail.oracle.com\0" "ref\020111102073928.GA23750@mwanda\0" "From\0Sunil Mushran <sunil.mushran@oracle.com>\0" - "Subject\0Re: [PATCH 1/2] fs/ocfs2/dlm: Eliminate update of list_for_each_entry\0" - "Date\0Wed, 02 Nov 2011 17:05:16 +0000\0" + "Subject\0Re: [PATCH 1/2] fs/ocfs2/dlm: Eliminate update of list_for_each_entry loop cursor\0" + "Date\0Wed, 02 Nov 2011 10:05:16 -0700\0" "To\0Dan Carpenter <dan.carpenter@oracle.com>\0" "Cc\0Julia Lawall <julia@diku.dk>" Mark Fasheh <mfasheh@suse.com> @@ -58,7 +58,7 @@ ">> \tHowever, this is not the correct solution. The goal of the\n" ">> original code, which used to use list_for_each(), was to leave lock\n" ">> non-NULL if the cookie was found. Your version merely exits the loop on\n" - ">> the first non-matching entry, always leaving lock=NULL if there is a\n" + ">> the first non-matching entry, always leaving lock==NULL if there is a\n" ">> non-matching entry.\n" ">> \tOne possible solution is to return the original code:\n" ">>\n" @@ -83,7 +83,7 @@ ">> +\t\t\t\tlist_for_each(iter, tmpq) {\n" ">> +\t\t\t\t\tlock = list_entry(iter, struct dlm_lock, list);\n" ">> +\n" - ">> +\t\t\t\t\tif (lock->ml.cookie = ml->cookie)\n" + ">> +\t\t\t\t\tif (lock->ml.cookie == ml->cookie)\n" ">> \t\t\t\t\t\tbreak;\n" ">> +\t\t\t\t\tlock = NULL;\n" ">> \t\t\t\t}\n" @@ -102,7 +102,7 @@ ">> -\t\t\t\t\tif (lock->ml.cookie != ml->cookie)\n" ">> -\t\t\t\t\t\tlock = NULL;\n" ">> -\t\t\t\t\telse\n" - ">> +\t\t\t\t\tif (lock->ml.cookie = ml->cookie)\n" + ">> +\t\t\t\t\tif (lock->ml.cookie == ml->cookie)\n" ">> \t\t\t\t\t\tbreak;\n" ">> \t\t\t\t}\n" ">> -\t\t\t\tif (lock)\n" @@ -134,4 +134,4 @@ ">> the body of a message to majordomo@vger.kernel.org\n" >> More majordomo info at http://vger.kernel.org/majordomo-info.html -2011f8a254e39911e277fbc63bd5c879eb792978955d5b80064a6bb29125bc83 +79a504faa70e81af3217eef9afa56a48f5a60158956f88712505b158d246067e
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.