From: Jeremy Fitzhardinge <jeremy@goop.org>
To: Ben Guthro <ben@guthro.net>
Cc: "H. Peter Anvin" <hpa@zytor.com>,
Jeremy Fitzhardinge <jeremy.fitzhardinge@citrix.com>,
the arch/x86 maintainers <x86@kernel.org>,
Xen Devel <xen-devel@lists.xensource.com>,
Tigran Aivazian <tigran@aivazian.fsnet.co.uk>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [Xen-devel] [PATCH 0/3] x86/microcode: support for microcode update in Xen dom0
Date: Thu, 03 Nov 2011 09:47:13 -0700 [thread overview]
Message-ID: <4EB2C591.6070202@goop.org> (raw)
In-Reply-To: <CAOvdn6VfZ524ku2DBMfmTV+dHGXrSV8Ls_iwHdm=ESXO9kUjcg@mail.gmail.com>
On 11/03/2011 08:06 AM, Ben Guthro wrote:
> After pulling in this change from your tree, I found the following
> bug, when checking an enum value, which should be considered before
> inclusion:
>
>
> diff --git a/arch/x86/kernel/microcode_xen.c
> b/arch/x86/kernel/microcode_xen.c
> index 9d2a06b..6a73957 100644
> --- a/arch/x86/kernel/microcode_xen.c
> +++ b/arch/x86/kernel/microcode_xen.c
> @@ -157,7 +157,7 @@ static enum ucode_state
> xen_request_microcode_user(int cpu,
> ret = UCODE_OK;
>
> out:
> -if (ret == 0)
> +if (ret == UCODE_OK)
> uci->mc = uc;
> else
> vfree(uc);
Thanks!
J
prev parent reply other threads:[~2011-11-03 16:47 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-26 18:17 [PATCH 0/3] x86/microcode: support for microcode update in Xen dom0 Jeremy Fitzhardinge
2011-09-26 18:18 ` [PATCH 1/3] xen/acpi: Domain0 acpi parser related platform hypercall Jeremy Fitzhardinge
2011-09-26 18:18 ` [PATCH 2/3] xen: add dom0_op hypercall Jeremy Fitzhardinge
2011-09-26 18:18 ` [PATCH 3/3] xen: add CPU microcode update driver Jeremy Fitzhardinge
2011-10-12 0:40 ` [PATCH 0/3] x86/microcode: support for microcode update in Xen dom0 Jeremy Fitzhardinge
2011-10-12 10:16 ` Borislav Petkov
2011-10-12 15:39 ` Jeremy Fitzhardinge
2011-10-12 15:39 ` Jeremy Fitzhardinge
2011-10-12 18:18 ` H. Peter Anvin
2011-10-12 19:18 ` Jeremy Fitzhardinge
2011-10-12 19:45 ` Borislav Petkov
2011-10-12 20:40 ` Konrad Rzeszutek Wilk
2011-10-12 21:31 ` H. Peter Anvin
2011-10-12 21:40 ` Borislav Petkov
2011-10-12 22:49 ` H. Peter Anvin
2011-10-12 23:40 ` Jeremy Fitzhardinge
2011-10-12 23:55 ` H. Peter Anvin
2011-10-13 0:00 ` Jeremy Fitzhardinge
2011-10-13 0:03 ` H. Peter Anvin
2011-10-13 7:00 ` Borislav Petkov
2012-01-04 0:49 ` Sven Köhler
2011-10-13 7:33 ` Borislav Petkov
2011-10-13 9:57 ` Borislav Petkov
2011-10-13 16:44 ` H. Peter Anvin
2011-10-17 17:08 ` [Xen-devel] " Konrad Rzeszutek Wilk
2011-10-17 17:40 ` H. Peter Anvin
2011-10-18 1:11 ` Henrique de Moraes Holschuh
2011-10-18 8:56 ` Christoph Egger
2011-10-18 9:35 ` Borislav Petkov
2011-10-18 9:49 ` Christoph Egger
[not found] ` <m2n.s.1RGYF2-136675@chiark.greenend.org.uk>
2011-10-25 16:53 ` Ian Jackson
2011-10-12 22:27 ` Jeremy Fitzhardinge
2011-10-12 22:29 ` H. Peter Anvin
2011-10-12 22:29 ` H. Peter Anvin
2011-10-12 22:33 ` Jeremy Fitzhardinge
2011-10-12 22:34 ` H. Peter Anvin
2011-10-12 22:38 ` Borislav Petkov
2011-10-12 20:22 ` H. Peter Anvin
2011-10-12 22:34 ` Jeremy Fitzhardinge
2011-10-12 22:36 ` H. Peter Anvin
[not found] ` <m2n.s.1RE5NW-151309@chiark.greenend.org.uk>
2011-10-17 13:47 ` [Xen-devel] " Ian Jackson
2011-11-03 15:06 ` Ben Guthro
2011-11-03 16:47 ` Jeremy Fitzhardinge [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4EB2C591.6070202@goop.org \
--to=jeremy@goop.org \
--cc=ben@guthro.net \
--cc=hpa@zytor.com \
--cc=jeremy.fitzhardinge@citrix.com \
--cc=linux-kernel@vger.kernel.org \
--cc=tigran@aivazian.fsnet.co.uk \
--cc=x86@kernel.org \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.