From: Greg Dietsche <gregory.dietsche@cuw.edu>
To: Greg Dietsche <Gregory.Dietsche@cuw.edu>
Cc: julia@diku.dk, Nicolas.Palix@inria.fr, rdunlap@xenotime.net,
Gilles.Muller@lip6.fr, cocci@diku.dk, linux-doc@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2 v3] coccicheck: add M= option to control which dir is processed
Date: Thu, 03 Nov 2011 20:17:56 -0500 [thread overview]
Message-ID: <4EB33D44.5070502@cuw.edu> (raw)
In-Reply-To: <1307814782-27415-1-git-send-email-Gregory.Dietsche@cuw.edu>
On 06/11/2011 12:53 PM, Greg Dietsche wrote:
> Examples:
> make coccicheck M=drivers/net/wireless/
> make coccicheck SUBDIRS=drivers/net/wireless/
>
> Version 2:
> fix patch file names when using M=
> tell coccinelle where the include files are
>
> Version 3:
> Add second include option to support out of tree development
> Fix error message
>
> Signed-off-by: Greg Dietsche <Gregory.Dietsche@cuw.edu>
> ---
> scripts/coccicheck | 19 ++++++++++++++-----
> 1 files changed, 14 insertions(+), 5 deletions(-)
>
> diff --git a/scripts/coccicheck b/scripts/coccicheck
> index 1bb1a1b..3c27764 100755
> --- a/scripts/coccicheck
> +++ b/scripts/coccicheck
> @@ -9,14 +9,23 @@ if [ "$C" = "1" -o "$C" = "2" ]; then
> # FLAGS="-ignore_unknown_options -very_quiet"
> # OPTIONS=$*
>
> -# Workaround for Coccinelle < 0.2.3
> - FLAGS="-I $srctree/include -very_quiet"
> - shift $(( $# - 1 ))
> - OPTIONS=$1
> + if [ "$KBUILD_EXTMOD" = "" ] ; then
> + # Workaround for Coccinelle < 0.2.3
> + FLAGS="-I $srctree/include -very_quiet"
> + shift $(( $# - 1 ))
> + OPTIONS=$1
> + else
> + echo M= is not currently supported when C=1 or C=2
> + exit 1
> + fi
> else
> ONLINE=0
> FLAGS="-very_quiet"
> - OPTIONS="-dir $srctree"
> + if [ "$KBUILD_EXTMOD" = "" ] ; then
> + OPTIONS="-dir $srctree"
> + else
> + OPTIONS="-dir $KBUILD_EXTMOD -patch $srctree -I $srctree/include -I $KBUILD_EXTMOD/include"
> + fi
> fi
>
> if [ ! -x "$SPATCH" ]; then
what's the process for getting this into the kernel tree?
Greg
next prev parent reply other threads:[~2011-11-04 1:55 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-08 3:29 coccicheck: Add M= option Greg Dietsche
2011-06-08 3:29 ` [PATCH 1/2] coccicheck: add M= option to control which dir is processed Greg Dietsche
2011-06-08 19:00 ` Greg Dietsche
2011-06-08 19:10 ` Nicolas Palix
2011-06-11 15:29 ` [PATCH 1/2 V2] " Greg Dietsche
2011-06-11 15:33 ` [PATCH 1/2] " Greg Dietsche
2011-06-11 15:40 ` Julia Lawall
2011-06-11 17:22 ` Greg Dietsche
2011-06-11 17:53 ` [PATCH 1/2 v3] " Greg Dietsche
2011-11-04 1:17 ` Greg Dietsche [this message]
2011-06-08 3:29 ` [PATCH 2/2] coccinelle.txt: update documentation to include M= option Greg Dietsche
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4EB33D44.5070502@cuw.edu \
--to=gregory.dietsche@cuw.edu \
--cc=Gilles.Muller@lip6.fr \
--cc=Nicolas.Palix@inria.fr \
--cc=cocci@diku.dk \
--cc=julia@diku.dk \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rdunlap@xenotime.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.