All of lore.kernel.org
 help / color / mirror / Atom feed
From: Martyn Welch <martyn.welch@ge.com>
To: Manohar Vanga <manohar.vanga@cern.ch>
Cc: gregkh@suse.de, cota@braap.org, devel@driverdev.osuosl.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/3] staging: vme: fix comment in __vme_register_driver()
Date: Fri, 04 Nov 2011 11:02:26 +0000	[thread overview]
Message-ID: <4EB3C642.5040304@ge.com> (raw)
In-Reply-To: <1320401551-29287-2-git-send-email-manohar.vanga@cern.ch>

On 04/11/11 10:12, Manohar Vanga wrote:
> Signed-off-by: Manohar Vanga <manohar.vanga@cern.ch>

Acked-by: Martyn Welch <martyn.welch@ge.com>

> ---
>  drivers/staging/vme/vme.c |    5 +----
>  1 files changed, 1 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/staging/vme/vme.c b/drivers/staging/vme/vme.c
> index b04b468..3cbc69c 100644
> --- a/drivers/staging/vme/vme.c
> +++ b/drivers/staging/vme/vme.c
> @@ -1421,10 +1421,7 @@ static int __vme_register_driver(struct vme_driver *drv, unsigned int ndevs)
>  		 * and if the bridge is removed, it will have to go through
>  		 * vme_unregister_bridge() to do it (which calls remove() on
>  		 * the bridge which in turn tries to acquire vme_buses_lock and
> -		 * will have to wait). The probe() called after device
> -		 * registration in __vme_register_driver below will also fail
> -		 * as the bridge is being removed (since the probe() calls
> -		 * vme_bridge_get()).
> +		 * will have to wait).
>  		 */
>  		err = __vme_register_driver_bus(drv, bridge, ndevs);
>  		if (err)


-- 
Martyn Welch (Principal Software Engineer) | Registered in England and
GE Intelligent Platforms                   | Wales (3828642) at 100
T +44(0)1327322748                         | Barbirolli Square, Manchester,
E martyn.welch@ge.com                      | M2 3AB  VAT:GB 927559189

  reply	other threads:[~2011-11-04 11:07 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-11-04 10:12 [PATCH 0/3] VME driver fixes Manohar Vanga
2011-11-04 10:12 ` [PATCH 1/3] staging: vme: fix comment in __vme_register_driver() Manohar Vanga
2011-11-04 11:02   ` Martyn Welch [this message]
2011-11-04 10:12 ` [PATCH 2/3] staging: vme: remove vme_add_bus() and vme_remove_bus() Manohar Vanga
2011-11-04 11:02   ` Martyn Welch
2011-11-04 10:12 ` [PATCH 3/3] staging: vme: fix comment for struct vme_dev Manohar Vanga
2011-11-04 11:03   ` Martyn Welch

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4EB3C642.5040304@ge.com \
    --to=martyn.welch@ge.com \
    --cc=cota@braap.org \
    --cc=devel@driverdev.osuosl.org \
    --cc=gregkh@suse.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=manohar.vanga@cern.ch \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.