Re: [Qemu-devel] [v8 Patch 5/6]Qemu: Framework for reopening images safely

[Supriya Kannery <supriyak@linux.vnet.ibm.com>]

On 11/04/2011 03:35 PM, Kevin Wolf wrote:
> Am 30.10.2011 11:35, schrieb Supriya Kannery:
>>
>> +struct BDRVReopenState {
>> +    BlockDriverState *bs;
>> +    int reopen_flags;
>> +
>> +    /* For raw-posix */
>> +    int reopen_fd;
>> +};
>
> I think I commented the same on the previous version: BDRVReopenState
> shouldn't contain any format specific fields. raw-posix must extend the
> struct like this and use container_of() to get it from a BDRVReopenState
> pointer:
>
> struct BDRVRawReopenState {
>      BDRVReopenState common;
>      int reopen_fd;
> };
>

I don't recall this was suggested in prev version or may be I missed to 
notice..
ok, will have raw extending common BDRVReopenState struct.


> Kevin
>