From mboxrd@z Thu Jan 1 00:00:00 1970 From: Juergen Gross Subject: Re: [PATCH] x86/IRQ: fix create_irq() after c/s 24068:6928172f7ded Date: Fri, 04 Nov 2011 14:01:44 +0100 Message-ID: <4EB3E238.7030205@ts.fujitsu.com> References: <4EB3E02B020000780005F027@nat28.tlf.novell.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <4EB3E02B020000780005F027@nat28.tlf.novell.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Jan Beulich Cc: "xen-devel@lists.xensource.com" List-Id: xen-devel@lists.xenproject.org On 11/04/2011 12:52 PM, Jan Beulich wrote: > init_one_irq_desc() must be called with interrupts enabled (as it may > call functions from the xmalloc() group). Rather than mis-using > vector_lock to also protect the finding of an unused IRQ, make this > lockless through using cmpxchg(), and obtain the lock only around the > actual assignment of the vector. Works for me (machine coming up again). Juergen -- Juergen Gross Principal Developer Operating Systems PDG ES&S SWE OS6 Telephone: +49 (0) 89 3222 2967 Fujitsu Technology Solutions e-mail: juergen.gross@ts.fujitsu.com Domagkstr. 28 Internet: ts.fujitsu.com D-80807 Muenchen Company details: ts.fujitsu.com/imprint.html