Re: [PATCH (resend) Version 2 3/3] NFSv4.1: fix backchennel bug

[Bryan Schumaker <bjschuma@netapp.com>]

"backchennel" in the subject should be "backchannel"

- Bryan

On 10/18/2011 02:39 AM, andros@netapp.com wrote:
> From: Andy Adamson <andros@netapp.com>
> 
> Slotid's start from 0 which means we check against
> NFS41_BC_MAX_CALLBACKS - 1.
> 
> Signed-off-by: Andy Adamson <andros@netapp.com>
> ---
>  fs/nfs/callback_proc.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/fs/nfs/callback_proc.c b/fs/nfs/callback_proc.c
> index 98ff5fc..12bd9d0 100644
> --- a/fs/nfs/callback_proc.c
> +++ b/fs/nfs/callback_proc.c
> @@ -339,7 +339,7 @@ validate_seqid(struct nfs4_slot_table *tbl, struct cb_sequenceargs * args)
>  	dprintk("%s enter. slotid %d seqid %d\n",
>  		__func__, args->csa_slotid, args->csa_sequenceid);
>  
> -	if (args->csa_slotid > NFS41_BC_MAX_CALLBACKS)
> +	if (args->csa_slotid > NFS41_BC_MAX_CALLBACKS - 1)
>  		return htonl(NFS4ERR_BADSLOT);
>  
>  	slot = nfs4_lookup_slot_locked(tbl, args->csa_slotid);