Re: [RFC PATCH v2] Tracepoint: add exec tracepoint

[David Smith <dsmith@redhat.com>]

On 11/04/2011 07:08 AM, Pedro Alves wrote:

> On Thursday 03 November 2011 15:59:48, David Smith wrote:
>> +                               if (depth == 0) {
>> +                                       trace_sched_process_exec(current, bprm);
>>                                         ptrace_event(PTRACE_EVENT_EXEC,
>>                                                         old_pid);
>> +                               }
> 
> Won't tracepoints be interested in the old pid as well?  Or does bprm
> carry that info?  That was only recently added to the ptrace event,
> which probably postdates your original patch.


Looking back at commit bb188d7 and the reasons why 'old_pid' was added,
it seems like a good idea to go ahead and add 'old_pid' to the
tracepoint as well.

v3 coming up...

Thanks for looking at this.

-- 
David Smith
dsmith@redhat.com
Red Hat
http://www.redhat.com
256.217.0141 (direct)
256.837.0057 (fax)