From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:49758)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <jcd@tribudubois.net>) id 1RN6mY-0004rJ-BM
	for qemu-devel@nongnu.org; Sun, 06 Nov 2011 12:45:23 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <jcd@tribudubois.net>) id 1RN6mW-0001Rl-Uj
	for qemu-devel@nongnu.org; Sun, 06 Nov 2011 12:45:22 -0500
Received: from mx1.w4a.fr ([178.33.204.49]:43772 helo=zose-store12.web4all.fr)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <jcd@tribudubois.net>) id 1RN6mW-0001Qy-Pm
	for qemu-devel@nongnu.org; Sun, 06 Nov 2011 12:45:20 -0500
Message-ID: <4EB6C7AC.9070100@tribudubois.net>
Date: Sun, 06 Nov 2011 18:45:16 +0100
From: Jean-Christophe DUBOIS <jcd@tribudubois.net>
MIME-Version: 1.0
References: <1320493322-4012-1-git-send-email-jcd@tribudubois.net>
	<CAFEAcA_rhEn_gyNAoJyjkv8exDPDQV9UBo=NsgrL6zXcpVzhQA@mail.gmail.com>
In-Reply-To: <CAFEAcA_rhEn_gyNAoJyjkv8exDPDQV9UBo=NsgrL6zXcpVzhQA@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v2] arm: Fix CP15 FSR (C5) domain setting
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: qemu-devel@nongnu.org, xvisor-devel@googlegroups.com

On 06/11/2011 18:33, Peter Maydell wrote:
> On 5 November 2011 11:42, Jean-Christophe DUBOIS<jcd@tribudubois.net>  wrote:
>> During Xvisor development, it was noted that qemu did not return
>> the correct domain value in the Cp15 [Data] FSR register (C5).
>>
>> This patch is a proposal to fix it.
>>
>> v2:
>> - fix coding style
>> - rebase on git.
>>
>> Signed-off-by: Jean-Christophe DUBOIS<jcd@tribudubois.net>
>
> Reviewed-by: Peter Maydell<peter.maydell@linaro.org>
>
> NB: not going to put this into 1.0, it's a bit late and it's not
> a critical bug fix IMHO. In particular, well behaved code shouldn't
> be relying on this DFSR field; see the ARM ARM B3.9.7:
> "From ARMv7, use of the domain field in the DFSR is deprecated. This
> field might not be supported in future versions of the ARM architecture.
> ARM strongly recommends that new software does not use this field."
Yes, same comment from the xvisor side of things. As xvisor targets 
mainly ARMv7 (and MIPS) for now, this was not a real issue.

Nonetheless this is worth fixing at some point in time (but this can be 
post 1.0).

JC
>
>
> -- PMM
>