From mboxrd@z Thu Jan 1 00:00:00 1970 From: Gerd Hoffmann Subject: Re: [PATCH 1.0] ac97: don't override the pci subsystem id Date: Mon, 07 Nov 2011 15:33:46 +0100 Message-ID: <4EB7EC4A.90607@redhat.com> References: <1320663634-29453-1-git-send-email-kraxel@redhat.com> <4EB7E896.9010108@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: qemu-devel@nongnu.org, kvm@vger.kernel.org, Takashi Iwai To: Avi Kivity Return-path: Received: from mx1.redhat.com ([209.132.183.28]:35057 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754418Ab1KGOdz (ORCPT ); Mon, 7 Nov 2011 09:33:55 -0500 In-Reply-To: <4EB7E896.9010108@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: On 11/07/11 15:17, Avi Kivity wrote: > On 11/07/2011 01:00 PM, Gerd Hoffmann wrote: >> This patch removes the code lines which set the subsystem id for the >> emulated ac97 card to 8086:0000. Due to the device id being zero the >> subsystem id isn't vaild anyway. With the patch applied the sound card >> gets the default qemu subsystem id (1af4:1100) instead. > > This a guest ABI change. Do we want -M support for it? Given that the old subsystem id isn't valid I'd say no unless someone comes up with a good reason. cheers, Gerd From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:58266) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RNQGr-0001am-67 for qemu-devel@nongnu.org; Mon, 07 Nov 2011 09:34:02 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RNQGl-0006FS-24 for qemu-devel@nongnu.org; Mon, 07 Nov 2011 09:33:56 -0500 Received: from mx1.redhat.com ([209.132.183.28]:15408) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RNQGk-0006FD-PJ for qemu-devel@nongnu.org; Mon, 07 Nov 2011 09:33:50 -0500 Message-ID: <4EB7EC4A.90607@redhat.com> Date: Mon, 07 Nov 2011 15:33:46 +0100 From: Gerd Hoffmann MIME-Version: 1.0 References: <1320663634-29453-1-git-send-email-kraxel@redhat.com> <4EB7E896.9010108@redhat.com> In-Reply-To: <4EB7E896.9010108@redhat.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 1.0] ac97: don't override the pci subsystem id List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Avi Kivity Cc: Takashi Iwai , qemu-devel@nongnu.org, kvm@vger.kernel.org On 11/07/11 15:17, Avi Kivity wrote: > On 11/07/2011 01:00 PM, Gerd Hoffmann wrote: >> This patch removes the code lines which set the subsystem id for the >> emulated ac97 card to 8086:0000. Due to the device id being zero the >> subsystem id isn't vaild anyway. With the patch applied the sound card >> gets the default qemu subsystem id (1af4:1100) instead. > > This a guest ABI change. Do we want -M support for it? Given that the old subsystem id isn't valid I'd say no unless someone comes up with a good reason. cheers, Gerd