From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [Qemu-devel] [PATCH 1.0] ac97: don't override the pci subsystem id Date: Mon, 07 Nov 2011 16:50:15 +0200 Message-ID: <4EB7F027.10209@redhat.com> References: <1320663634-29453-1-git-send-email-kraxel@redhat.com> <4EB7E896.9010108@redhat.com> <4EB7EC4A.90607@redhat.com> <4EB7EE62.7070805@redhat.com> <4EB7EEDD.4090604@codemonkey.ws> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: Gerd Hoffmann , Takashi Iwai , qemu-devel@nongnu.org, kvm@vger.kernel.org To: Anthony Liguori Return-path: Received: from mx1.redhat.com ([209.132.183.28]:63647 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751464Ab1KGOuX (ORCPT ); Mon, 7 Nov 2011 09:50:23 -0500 In-Reply-To: <4EB7EEDD.4090604@codemonkey.ws> Sender: kvm-owner@vger.kernel.org List-ID: On 11/07/2011 04:44 PM, Anthony Liguori wrote: >>>> This a guest ABI change. Do we want -M support for it? >>> >>> Given that the old subsystem id isn't valid I'd say no unless someone >>> comes up with a good reason. >> >> Do we know that Windows won't complain about it? > > > I thought the original motivation for the default subsystem ids was > that some Windows test suite was explicitly complaining about having > invalid subsystem ids? I think so, but that's unrelated. The worry is that some DRM code checksums your hardware and complains if it changed too much. Nothing to do with the test suite. The sense of Gerd's comment is reversed. We should preserve the ABI unless there is a strong reason not to. -- error compiling committee.c: too many arguments to function From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:51176) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RNQWp-0003s0-E5 for qemu-devel@nongnu.org; Mon, 07 Nov 2011 09:50:33 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RNQWj-0000Rs-TT for qemu-devel@nongnu.org; Mon, 07 Nov 2011 09:50:27 -0500 Received: from mx1.redhat.com ([209.132.183.28]:4980) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RNQWj-0000Rh-Ly for qemu-devel@nongnu.org; Mon, 07 Nov 2011 09:50:21 -0500 Message-ID: <4EB7F027.10209@redhat.com> Date: Mon, 07 Nov 2011 16:50:15 +0200 From: Avi Kivity MIME-Version: 1.0 References: <1320663634-29453-1-git-send-email-kraxel@redhat.com> <4EB7E896.9010108@redhat.com> <4EB7EC4A.90607@redhat.com> <4EB7EE62.7070805@redhat.com> <4EB7EEDD.4090604@codemonkey.ws> In-Reply-To: <4EB7EEDD.4090604@codemonkey.ws> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 1.0] ac97: don't override the pci subsystem id List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Anthony Liguori Cc: Takashi Iwai , Gerd Hoffmann , kvm@vger.kernel.org, qemu-devel@nongnu.org On 11/07/2011 04:44 PM, Anthony Liguori wrote: >>>> This a guest ABI change. Do we want -M support for it? >>> >>> Given that the old subsystem id isn't valid I'd say no unless someone >>> comes up with a good reason. >> >> Do we know that Windows won't complain about it? > > > I thought the original motivation for the default subsystem ids was > that some Windows test suite was explicitly complaining about having > invalid subsystem ids? I think so, but that's unrelated. The worry is that some DRM code checksums your hardware and complains if it changed too much. Nothing to do with the test suite. The sense of Gerd's comment is reversed. We should preserve the ABI unless there is a strong reason not to. -- error compiling committee.c: too many arguments to function