From: Paul Gortmaker <paul.gortmaker@windriver.com>
To: Axel Lin <axel.lin@gmail.com>
Cc: <linux-kernel@vger.kernel.org>,
Mattias Wallin <mattias.wallin@stericsson.com>,
Linus Walleij <linus.walleij@linaro.org>,
Samuel Ortiz <sameo@linux.intel.com>
Subject: Re: [PATCH 2/2] mfd: include linux/module.h for ab5500-debugfs
Date: Mon, 7 Nov 2011 11:16:11 -0500 [thread overview]
Message-ID: <4EB8044B.7020403@windriver.com> (raw)
In-Reply-To: <1320636009.10415.2.camel@phoenix>
On 11-11-06 10:20 PM, Axel Lin wrote:
> Include linux/module.h to fix below build error:
>
> CC drivers/mfd/ab5500-debugfs.o
> drivers/mfd/ab5500-debugfs.c:571: error: 'THIS_MODULE' undeclared here (not in a function)
> make[2]: *** [drivers/mfd/ab5500-debugfs.o] Error 1
>
> Signed-off-by: Axel Lin <axel.lin@gmail.com>
> ---
> drivers/mfd/ab5500-debugfs.c | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/mfd/ab5500-debugfs.c b/drivers/mfd/ab5500-debugfs.c
> index 6be1fe6..b7b2d348 100644
> --- a/drivers/mfd/ab5500-debugfs.c
> +++ b/drivers/mfd/ab5500-debugfs.c
> @@ -4,6 +4,7 @@
> * Debugfs support for the AB5500 MFD driver
> */
>
> +#include <linux/module.h>
This one looks incorrect. I don't see any uses of MODULE_* or
module_* in the file, so I'll make a commit for it to use export.h
and retest.
P.
> #include <linux/debugfs.h>
> #include <linux/seq_file.h>
> #include <linux/mfd/ab5500/ab5500.h>
next prev parent reply other threads:[~2011-11-07 16:18 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-07 3:19 [PATCH 1/2] mfd: include linux/module.h for ab5500-core Axel Lin
2011-11-07 3:20 ` [PATCH 2/2] mfd: include linux/module.h for ab5500-debugfs Axel Lin
2011-11-07 8:32 ` Linus Walleij
2011-11-07 16:16 ` Paul Gortmaker [this message]
2011-11-08 2:57 ` Axel Lin
2011-11-08 3:14 ` Axel Lin
2011-11-07 8:11 ` [PATCH 1/2] mfd: include linux/module.h for ab5500-core Linus Walleij
2011-11-14 0:19 ` Samuel Ortiz
2011-11-14 17:41 ` Paul Gortmaker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4EB8044B.7020403@windriver.com \
--to=paul.gortmaker@windriver.com \
--cc=axel.lin@gmail.com \
--cc=linus.walleij@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mattias.wallin@stericsson.com \
--cc=sameo@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.