From: Larry Finger <Larry.Finger@lwfinger.net>
To: Jesper Juhl <jj@chaosbits.net>
Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org,
Andrea Merello <andreamrl@tiscali.it>,
Mike McCormack <mikem@ring3k.org>,
Greg Kroah-Hartman <gregkh@suse.de>,
netdev@vger.kernel.org
Subject: Re: [PATCH] rtl8192e: Don't copy huge struct by value (and make it const).
Date: Mon, 07 Nov 2011 10:55:46 -0600 [thread overview]
Message-ID: <4EB80D92.8050507@lwfinger.net> (raw)
In-Reply-To: <alpine.LNX.2.00.1111070017220.5763@swampdragon.chaosbits.net>
On 11/06/2011 05:21 PM, Jesper Juhl wrote:
> rtllib_is_shortslot() takes one argument - a struct that's more than a
> kilobyte large. It should take a pointer instead of copying such a
> huge struct - and the argument might as well be declared 'const' now
> that we are at it, since it is not modified. This patch makes these
> changes.
>
> Signed-off-by: Jesper Juhl<jj@chaosbits.net>
Acked-by: Larry Finger <Larry.Finger@lwfinger.net>
prev parent reply other threads:[~2011-11-07 16:55 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-06 23:21 [PATCH] rtl8192e: Don't copy huge struct by value (and make it const) Jesper Juhl
2011-11-07 16:55 ` Larry Finger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4EB80D92.8050507@lwfinger.net \
--to=larry.finger@lwfinger.net \
--cc=andreamrl@tiscali.it \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@suse.de \
--cc=jj@chaosbits.net \
--cc=linux-kernel@vger.kernel.org \
--cc=mikem@ring3k.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.