From: Kalle Valo <kvalo@qca.qualcomm.com>
To: Raja Mani <rmani@qca.qualcomm.com>
Cc: <linux-wireless@vger.kernel.org>
Subject: Re: [PATCH v2 10/11] ath6kl: Remove WARN_ON msg in Suspend path
Date: Mon, 7 Nov 2011 23:05:00 +0200 [thread overview]
Message-ID: <4EB847FC.9040209@qca.qualcomm.com> (raw)
In-Reply-To: <1320643547-3578-11-git-send-email-rmani@qca.qualcomm.com>
On 11/07/2011 07:25 AM, Raja Mani wrote:
> In the current code, WOW resume is executed first from RX path
> and ar->state is moved to ATH6KL_STATE_ON. When platform calls
> ath6kl_sdio_resume() in CFG resume context, that time ar->state
> could have moved to ON state. Printing WARN_ON(1) is void in
> this context. Hence removing this.
>
> Once WOW resume is removed from RX path, This WARN_ON msg can be
> reverted.
I changed places with this and patch 9. This is to avoid useless
warnings during bisect.
Kalle
next prev parent reply other threads:[~2011-11-07 21:05 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-07 5:25 [PATCH v2 00/11] ath6kl: Add WOW support Raja Mani
2011-11-07 5:25 ` [PATCH v2 01/11] ath6kl: Add wmi functions to add/delete WOW patterns Raja Mani
2011-11-07 5:25 ` [PATCH v2 02/11] ath6kl: Add wmi functions to configure WOW mode and host sleep mode Raja Mani
2011-11-07 5:25 ` [PATCH v2 03/11] ath6kl: Add WOW suspend/resume implementation Raja Mani
2011-11-07 5:25 ` [PATCH v2 04/11] ath6kl: Include new parameter in suspend path for wowlan Raja Mani
2011-11-07 5:25 ` [PATCH v2 05/11] ath6kl: Add new state for WOW mode Raja Mani
2011-11-07 5:25 ` [PATCH v2 06/11] ath6kl: Move ath6kl_cfg80211_stop() call specific to deep sleep and cut pwr Raja Mani
2011-11-07 5:25 ` [PATCH v2 07/11] ath6kl: Invoke WOW suspend/resume calls during PM operation Raja Mani
2011-11-07 21:03 ` Kalle Valo
2011-11-07 5:25 ` [PATCH v2 08/11] ath6kl: Perform WOW resume in RX path in case of SDIO IRQ wake up Raja Mani
2011-11-07 5:25 ` [PATCH v2 09/11] ath6kl: Expose ath6kl's WOW capabilities to CFG layer Raja Mani
2011-11-07 5:25 ` [PATCH v2 10/11] ath6kl: Remove WARN_ON msg in Suspend path Raja Mani
2011-11-07 21:05 ` Kalle Valo [this message]
2011-11-07 5:25 ` [PATCH v2 11/11] ath6kl: Remove few unused WMI stuff Raja Mani
2011-11-07 21:02 ` [PATCH v2 00/11] ath6kl: Add WOW support Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4EB847FC.9040209@qca.qualcomm.com \
--to=kvalo@qca.qualcomm.com \
--cc=linux-wireless@vger.kernel.org \
--cc=rmani@qca.qualcomm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.